Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for verifying distinct messages, signed by distinct entities with an aggregated signature. #5

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Fronsto
Copy link

@Fronsto Fronsto commented Apr 17, 2024

Resolves #3 ,
Added support for verifying distinct messages. Previously all the messages signed by distinct entities needed to be same.

Copy link
Owner

@asonnino asonnino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should implement a counter-measure again rogue public key attacks: https://crypto.stanford.edu/~dabo/pubs/papers/BLSmultisig.html

We could go with the simplest, namely ensuring that all messages are different in aggregate_verify.

@Fronsto
Copy link
Author

Fronsto commented Apr 19, 2024

Yeah makes sense. I've updated the code and created a new function sign_unique that appends public key to the message to be signed, and similar modification in aggregate_verify, thus making sure the messages with be different.

@Fronsto
Copy link
Author

Fronsto commented Apr 24, 2024

I've made that change. This will ensure now that the supplied vks in aggregate_verify are different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lagrange_basis functions throws an error
2 participants