noissue: Compute no defaulted values.

atlassian · May 19, 2019 · 9095048 · 9095048
1 parent b71611d
commit 9095048
Show file tree

Hide file tree

Showing 6 changed files with 59 additions and 0 deletions.
diff --git a/pkg/artifactory/resource_artifactory_group.go b/pkg/artifactory/resource_artifactory_group.go
@@ -35,14 +35,17 @@ func resourceArtifactoryGroup() *schema.Resource {
 			"auto_join": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"admin_privileges": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"realm": {
 				Type:         schema.TypeString,
 				Optional:     true,
+				Computed:     true,
 				ValidateFunc: validateLowerCase,
 			},
 			"realm_attributes": {

diff --git a/pkg/artifactory/resource_artifactory_local_repository.go b/pkg/artifactory/resource_artifactory_local_repository.go
@@ -31,6 +31,7 @@ func resourceArtifactoryLocalRepository() *schema.Resource {
 				Type:     schema.TypeString,
 				Optional: true,
 				ForceNew: true,
+				Computed: true,
 			},
 			"description": {
 				Type:     schema.TypeString,
@@ -43,10 +44,12 @@ func resourceArtifactoryLocalRepository() *schema.Resource {
 			"includes_pattern": {
 				Type:     schema.TypeString,
 				Optional: true,
+				Computed: true,
 			},
 			"excludes_pattern": {
 				Type:     schema.TypeString,
 				Optional: true,
+				Computed: true,
 			},
 			"repo_layout_ref": {
 				Type:     schema.TypeString,
@@ -56,14 +59,17 @@ func resourceArtifactoryLocalRepository() *schema.Resource {
 			"handle_releases": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"handle_snapshots": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"max_unique_snapshots": {
 				Type:     schema.TypeInt,
 				Optional: true,
+				Computed: true,
 			},
 			"debian_trivial_layout": {
 				Type:     schema.TypeBool,
@@ -72,22 +78,27 @@ func resourceArtifactoryLocalRepository() *schema.Resource {
 			"checksum_policy_type": {
 				Type:     schema.TypeString,
 				Optional: true,
+				Computed: true,
 			},
 			"max_unique_tags": {
 				Type:     schema.TypeInt,
 				Optional: true,
+				Computed: true,
 			},
 			"snapshot_version_behavior": {
 				Type:     schema.TypeString,
 				Optional: true,
+				Computed: true,
 			},
 			"suppress_pom_consistency_checks": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"blacked_out": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"property_sets": {
 				Type:     schema.TypeSet,
@@ -110,14 +121,17 @@ func resourceArtifactoryLocalRepository() *schema.Resource {
 			"docker_api_version": {
 				Type:     schema.TypeString,
 				Optional: true,
+				Computed: true,
 			},
 			"enable_file_lists_indexing": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"xray_index": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 		},
 	}

diff --git a/pkg/artifactory/resource_artifactory_remote_repository.go b/pkg/artifactory/resource_artifactory_remote_repository.go
@@ -48,10 +48,12 @@ func resourceArtifactoryRemoteRepository() *schema.Resource {
 			"includes_pattern": {
 				Type:     schema.TypeString,
 				Optional: true,
+				Computed: true,
 			},
 			"excludes_pattern": {
 				Type:     schema.TypeString,
 				Optional: true,
+				Computed: true,
 			},
 			"repo_layout_ref": {
 				Type:     schema.TypeString,
@@ -60,18 +62,22 @@ func resourceArtifactoryRemoteRepository() *schema.Resource {
 			"handle_releases": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"handle_snapshots": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"max_unique_snapshots": {
 				Type:     schema.TypeInt,
 				Optional: true,
+				Computed: true,
 			},
 			"suppress_pom_consistency_checks": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"url": {
 				Type:     schema.TypeString,
@@ -94,6 +100,7 @@ func resourceArtifactoryRemoteRepository() *schema.Resource {
 			"remote_repo_checksum_policy_type": {
 				Type:     schema.TypeString,
 				Optional: true,
+				Computed: true,
 				ValidateFunc: validation.StringInSlice([]string{
 					"generate-if-absent",
 					"fail",
@@ -104,22 +111,27 @@ func resourceArtifactoryRemoteRepository() *schema.Resource {
 			"hard_fail": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"offline": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"blacked_out": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"store_artifacts_locally": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"socket_timeout_millis": {
 				Type:     schema.TypeInt,
 				Optional: true,
+				Computed: true,
 			},
 			"local_address": {
 				Type:     schema.TypeString,
@@ -128,34 +140,42 @@ func resourceArtifactoryRemoteRepository() *schema.Resource {
 			"retrieval_cache_period_seconds": {
 				Type:     schema.TypeInt,
 				Optional: true,
+				Computed: true,
 			},
 			"missed_cache_period_seconds": {
 				Type:     schema.TypeInt,
 				Optional: true,
+				Computed: true,
 			},
 			"unused_artifacts_cleanup_period_hours": {
 				Type:     schema.TypeInt,
 				Optional: true,
+				Computed: true,
 			},
 			"fetch_jars_eagerly": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"fetch_sources_eagerly": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"share_configuration": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"synchronize_properties": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"block_mismatching_mime_types": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"property_sets": {
 				Type:     schema.TypeSet,
@@ -166,46 +186,57 @@ func resourceArtifactoryRemoteRepository() *schema.Resource {
 			"allow_any_host_auth": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"enable_cookie_management": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"client_tls_certificate": {
 				Type:     schema.TypeString,
 				Optional: true,
+				Computed: true,
 			},
 			"pypi_registry_url": {
 				Type:     schema.TypeString,
 				Optional: true,
+				Computed: true,
 			},
 			"bower_registry_url": {
 				Type:     schema.TypeString,
 				Optional: true,
+				Computed: true,
 			},
 			"bypass_head_requests": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"enable_token_authentication": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"xray_index": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"vcs_type": {
 				Type:     schema.TypeString,
 				Optional: true,
+				Computed: true,
 			},
 			"vcs_git_provider": {
 				Type:     schema.TypeString,
 				Optional: true,
+				Computed: true,
 			},
 			"vcs_git_download_url": {
 				Type:     schema.TypeString,
 				Optional: true,
+				Computed: true,
 			},
 			"feed_context_path": {
 				Type:          schema.TypeString,

diff --git a/pkg/artifactory/resource_artifactory_replication_config.go b/pkg/artifactory/resource_artifactory_replication_config.go
@@ -34,6 +34,7 @@ func resourceArtifactoryReplicationConfig() *schema.Resource {
 			"enable_event_replication": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"replications": {
 				Type:     schema.TypeList,
@@ -48,6 +49,7 @@ func resourceArtifactoryReplicationConfig() *schema.Resource {
 						"socket_timeout_millis": {
 							Type:     schema.TypeInt,
 							Optional: true,
+							Computed: true,
 						},
 						"username": {
 							Type:     schema.TypeString,
@@ -62,18 +64,22 @@ func resourceArtifactoryReplicationConfig() *schema.Resource {
 						"enabled": {
 							Type:     schema.TypeBool,
 							Optional: true,
+							Computed: true,
 						},
 						"sync_deletes": {
 							Type:     schema.TypeBool,
 							Optional: true,
+							Computed: true,
 						},
 						"sync_properties": {
 							Type:     schema.TypeBool,
 							Optional: true,
+							Computed: true,
 						},
 						"sync_statistics": {
 							Type:     schema.TypeBool,
 							Optional: true,
+							Computed: true,
 						},
 						"path_prefix": {
 							Type:     schema.TypeString,

diff --git a/pkg/artifactory/resource_artifactory_user.go b/pkg/artifactory/resource_artifactory_user.go
@@ -40,18 +40,22 @@ func resourceArtifactoryUser() *schema.Resource {
 			"admin": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"profile_updatable": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"disable_ui_access": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"internal_password_disabled": {
 				Type:     schema.TypeBool,
 				Optional: true,
+				Computed: true,
 			},
 			"groups": {
 				Type:     schema.TypeSet,

diff --git a/pkg/artifactory/resource_artifactory_virtual_repository.go b/pkg/artifactory/resource_artifactory_virtual_repository.go
@@ -74,6 +74,7 @@ func resourceArtifactoryVirtualRepository() *schema.Resource {
 			"pom_repository_references_cleanup_policy": {
 				Type:     schema.TypeString,
 				Optional: true,
+				Computed: true,
 			},
 			"default_deployment_repo": {
 				Type:     schema.TypeString,