Changes durations in the time module to use u64 instead of u32
#820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for durations instead of `u32` * This allows for delays and durations longer than 4 seconds in parts of the HAL where durations are stored or passed in nanoseconds. * Also ensures that the type defs in the `time` module are used throughout the HAL, as some places still imported and used `fugit` durations explicitly. * Replaces `fugit::ExtU32` in the prelude with `fugit::ExtU64`, and also adds `fugit::ExtU64Ceil`. examples: Updates applicable examples to use the HAL duration types instead of those directly from `fugit` * feather_m0: async_timer * metro_m4: async_timer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently many time durations pass/stored throughout the HAL use nanoseconds for maximum precision. However these are stored using a
u32for a maximum of about 4 seconds. Since delays/times longer than this could be useful and should be possible, this changes all type defs in thetimemodule to useu64instead, extending the maximum time (when stored as nanoseconds) to over 584 years.There were also several places in the HAL that import
fugitduration types directly. These were changed to use the type defs in thetimetime module instead so that the entire HAL uses these exclusively.See the commit message for more details.
Note that the rate/frequency types defined in
timestill useu32as rates above 4 GHz are not likely to be useful.Also note that this is a breaking change.
Checklist
#[allow]certain lints where reasonable, but ideally justify those with a short comment.