Fix netkitten memory leak from infinite deferred functions (#4284)

aws · Aug 15, 2024 · c9c7482 · c9c7482
1 parent fd8cbef
commit c9c7482
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/misc/netkitten/netkitten.go b/misc/netkitten/netkitten.go
@@ -44,11 +44,6 @@ func main() {
 	for {
 		// If given a target, work with it first
 		var cconn net.Conn
-		defer func() {
-			if cconn != nil {
-				cconn.Close()
-			}
-		}()
 		if target != "" {
 			var err error
 			cconn, err = net.Dial("tcp", target)
@@ -82,6 +77,7 @@ func main() {
 			conn.Close()
 		} else if cconn != nil {
 			io.Copy(os.Stdout, cconn)
+			cconn.Close()
 		}
 
 		if !*loop {