Add ability to disable some functionality via features #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes you may not have proper libssl/libcrypt, so it make sense to add ability to disable them.
openssl.org is unavailable... |
$ curl --head https://openssl.org/ curl: (7) Failed to connect to openssl.org port 443 after 2928 ms: Couldn't connect to server $ curl --head https://www.openssl.org/ HTTP/1.1 200 OK Server: Apache/2.4.52 (Ubuntu) Strict-Transport-Security: max-age=31536000; includeSubDomains; preload Content-Type: text/html; charset=UTF-8 Cache-Control: max-age=29521 Expires: Mon, 25 Dec 2023 03:29:26 GMT Date: Sun, 24 Dec 2023 19:17:25 GMT Connection: keep-alive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
And also add new build to CI to ensure that this configuration will not be broken.