Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recurse to correct rule for nested expand paths #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petrosagg
Copy link

Fixes inputs like /resource?$expand=foo/bar($filter=foo)

Change-type: patch
Signed-off-by: Petros Angelatos [email protected]

Fixes inputs like /resource?$expand=foo/bar($filter=foo)

Change-type: patch
Signed-off-by: Petros Angelatos <[email protected]>
@petrosagg petrosagg requested a review from Page- December 6, 2018 09:13
Copy link
Collaborator

@Page- Page- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will also enable doing

$expand=a($top=1)/b($select=c)

is that also valid?

@petrosagg
Copy link
Author

yes

@petrosagg
Copy link
Author

@Page- ping

1 similar comment
@petrosagg
Copy link
Author

@Page- ping

@Page-
Copy link
Collaborator

Page- commented Dec 19, 2018

Sorry @petrosagg didn't see this - the best way to get my attention on reviews is to request a review (or rereview) - just add me to the reviewers list again and it appears in the https://github.com/pulls/review-requested list

Page-
Page- previously approved these changes Dec 19, 2018
@kaisoz kaisoz added the versionbot/pr-draft Draft PR - Don't merge this PR automatically label Jun 10, 2020
@ghost ghost dismissed Page-’s stale review June 10, 2020 15:42

Approval reviews not allowed in Draft PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
versionbot/pr-draft Draft PR - Don't merge this PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants