Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contracts/hw.device-type: Update instructions for Orin flasher types #448

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

acostach
Copy link
Contributor

@acostach acostach commented Dec 5, 2024

Copy link
Member

@vipulgupta2048 vipulgupta2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow similar review on the other 3 files as well since the changes are similar.

Comment on lines 32 to 33
"For balenaOS versions v6.1.16 and newer, please ensure your device is running UEFI firmware version 36.3. Click <a href=\"https://docs.balena.io/learn/develop/jetson-orin#uefi-firmware\">here</a> for details on how to check or update your firmware version.",
"For balenaOS versions older than v6.1.16, please refer to the <a href=\"https://github.com/balena-os/jetson-flash?tab=readme-ov-file\">{{name}} legacy flashing</a> guide.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"For balenaOS versions v6.1.16 and newer, please ensure your device is running UEFI firmware version 36.3. Click <a href=\"https://docs.balena.io/learn/develop/jetson-orin#uefi-firmware\">here</a> for details on how to check or update your firmware version.",
"For balenaOS versions older than v6.1.16, please refer to the <a href=\"https://github.com/balena-os/jetson-flash?tab=readme-ov-file\">{{name}} legacy flashing</a> guide.",
"For balenaOS versions v6.1.16 and newer, please ensure your device is running UEFI firmware version 36.3. Check and update the<a href=\"https://docs.balena.io/learn/develop/jetson-orin#uefi-firmware\">firmware version</a> before proceeding.",
"For balenaOS versions older than v6.1.16, please refer to the <a href=\"https://github.com/balena-os/jetson-flash?tab=readme-ov-file\">{{name}} legacy flashing</a> guide.",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"instructions": [
"For balenaOS versions v6.1.16 and newer, please ensure your device is running UEFI firmware version 36.3. Click <a href=\"https://docs.balena.io/learn/develop/jetson-orin#uefi-firmware\">here</a> for details on how to check or update your firmware version.",
"For balenaOS versions older than v6.1.16, please refer to the <a href=\"https://github.com/balena-os/jetson-flash?tab=readme-ov-file\">{{name}} legacy flashing</a> guide.",
"Use the form on the left to configure and download balenaOS for your new device."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Use the form on the left to configure and download balenaOS for your new device."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already in the dashboard instructions as the first line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vipulgupta2048 , I guess that overriding instructions does not remove that sentence. In this case I'll remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

],
"flashIndicator": ["power LED is off"],
"bootDevice": ["Power up the {{name}}"]
"bootDevice": ["Power up the {{name}}. A progress bar will show up on the display while the UEFI firmware is updated. Please do not interrupt this process by cutting power or rebooting the device."]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"bootDevice": ["Power up the {{name}}. A progress bar will show up on the display while the UEFI firmware is updated. Please do not interrupt this process by cutting power or rebooting the device."]
"bootDevice": ["Power up the {{name}}. A progress bar will show up on the display while the UEFI firmware is updated. Please do not interrupt this process by turning off power or rebooting the device."]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Signed-off-by: Alexandru Costache <[email protected]>
"Connect the USB-C data port of the Devkit to the Host PC.",
"Boot the device from the inserted USB Key by following the <a href=\"https://github.com/balena-os/jetson-flash#agx-orin-devkit-64gb-flashing\">AGX Orin Devkit 64GB flashing steps</a>."
"Power on the {{name}}.",
"NOTE: Only If your device is already flashed with a balenaOS version older than v6.1.16, power it on and interrupt booting by pressing the 'Esc' key when prompted by the UEFI firmware. Enter the Boot Manager Menu of the UEFI firmware and select the attached USB key as boot media, to trigger the provisioning process."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"NOTE: Only If your device is already flashed with a balenaOS version older than v6.1.16, power it on and interrupt booting by pressing the 'Esc' key when prompted by the UEFI firmware. Enter the Boot Manager Menu of the UEFI firmware and select the attached USB key as boot media, to trigger the provisioning process."
"Note: Only if your device is already flashed with a balenaOS version older than v6.1.16, power it on and interrupt booting by pressing the 'Esc' key when prompted by the UEFI firmware. Enter the Boot Manager Menu of the UEFI firmware and select the attached USB key as boot media, to trigger the provisioning process."

NIT

@flowzone-app flowzone-app bot merged commit 1cc20f9 into master Dec 16, 2024
53 checks passed
@flowzone-app flowzone-app bot deleted the update_orin_instructions branch December 16, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants