Improve testing of contracts #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipex
force-pushed
the
improve-testing
branch
5 times, most recently
from
24f1cda to
cd3a2ae
Compare
pipex
force-pushed
the
improve-testing
branch
from
cd3a2ae to
ba84370
Compare
pipex
force-pushed
the
improve-testing
branch
2 times, most recently
from
d209e16 to
0c0a485
Compare
pipex
force-pushed
the
improve-testing
branch
2 times, most recently
from
182185c to
c05b87a
Compare
pipex
force-pushed
the
improve-testing
branch
from
c05b87a to
9a641a9
Compare
alexgg
reviewed
Feb 3, 2025
There was a problem hiding this comment.
I can't think of anything using the sw.os-image contract so I'm not against it. About the tests, I'm afraid I don't know enough about the repo to review. If nobody else does let me know and I can unblock with an approval, but at least a js developer should ack I think.
Thank you, I thought you might say that, but I also wanted some ack that it was OK to remove the os-image contract. |
Page-
reviewed
Feb 4, 2025
Change-type: patch
- Migrates contracts to typescript - Parallelizes scanning of folders and loading contracts - Adds validation for internal consistency of the contract universe Change-type: patch
pipex
force-pushed
the
improve-testing
branch
from
9a641a9 to
072ab72
Compare
Page-
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sw.os-imagecontracts (which also interferes with internal consistency)Change-type: patch