Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable IPv6 connectivity for the kamal network #1381

Closed
wants to merge 2 commits into from

Conversation

frenkel
Copy link

@frenkel frenkel commented Jan 27, 2025

Based on #1280 I've updated the tests as well.
This change is needed if you want to receive the client IPv6 address in your Rails app. Without it you'll only get the IPv4 address of the docker proxy (172.x.x.x).

@djmb
Copy link
Collaborator

djmb commented Jan 30, 2025

The integration tests are failing with "Error response from daemon: could not find an available, non-overlapping IPv6 address pool among the defaults to assign to the network".

This might just be from running docker inside docker, but it highlights that maybe this isn't a safe change in all contexts.

From the latest changes in main, the pre-deploy hook will always run before attempting to create the network, so the best solution here might be to use that to create a kamal network with whatever options you want.

@frenkel
Copy link
Author

frenkel commented Jan 30, 2025

Indeed, you would need some options in your docker file (or pass them as arguments). Hadn't thought about that and locally I did have those probably.

pre-deploy seems like a better solution, thanks for the hint! You might want to close #1280 then as well.

@frenkel frenkel closed this Jan 30, 2025
@frenkel frenkel deleted the kamal-ipv6 branch January 30, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants