Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gum installer #232

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Fix gum installer #232

merged 3 commits into from
Jul 25, 2024

Conversation

cyommer
Copy link
Contributor

@cyommer cyommer commented Jul 25, 2024

As noted in issue #230, the app_gum.sh script contains a fragile link to the gum installer:

# Gum is used for the Omakub commands for tailoring Omakub after the initial install
cd /tmp
GUM_VERSION="0.14.1" # Use known good version
wget -qO gum.deb "https://github.com/charmbracelet/gum/releases/latest/download/gum_${GUM_VERSION}_amd64.deb"
sudo apt-get install -y ./gum.deb
rm gum.deb
cd -

This update changes that link to always point to the version specified in the variable declaration. The updated link looks like this:

wget -qO gum.deb "https://github.com/charmbracelet/gum/releases/download/v${GUM_VERSION}/gum_${GUM_VERSION}_amd64.deb"

This has been tested on a fresh install of Ubuntu 24.04.

@dhh
Copy link
Member

dhh commented Jul 25, 2024

Closes #231

@dhh dhh merged commit 9f900e1 into basecamp:master Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants