Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain why vendored repositories are considered out-of-date #24857

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Explain why vendored repositories are considered out-of-date #24857

wants to merge 2 commits into from
+178 −136

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 8, 2025

Work towards #23243

@fmeum fmeum removed the request for review from lberki January 8, 2025 12:15
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Jan 8, 2025
@fmeum fmeum force-pushed the 23243-explain-invalidation branch from 30ebaf3 to cf07137 Compare January 8, 2025 12:18
meteorcloudy
meteorcloudy reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, can you please take a look at the presubmit failures and update/add the test cases?

@fmeum fmeum force-pushed the 23243-explain-invalidation branch from cf07137 to 9018577 Compare January 8, 2025 13:43
@fmeum fmeum requested a review from meteorcloudy January 8, 2025 15:46
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 8, 2025

@bazel-io fork 8.1.0

@bazel-io bazel-io mentioned this pull request Jan 8, 2025
Open
meteorcloudy
meteorcloudy approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but wait for @Wyverald to also take a look

@meteorcloudy
Copy link
Member

Ping @Wyverald !

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@Wyverald Wyverald Awaiting requested review from Wyverald Wyverald is a code owner

Assignees
No one assigned
Labels
awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmeum @meteorcloudy