Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sh_toolchain: Fix broken alias #24961

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sh_toolchain: Fix broken alias #24961

wants to merge 1 commit into from
+1 −1

Conversation

BoleynSu
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jan 18, 2025
@BoleynSu
Copy link
Contributor Author

@fmeum for info

@fmeum
Copy link
Collaborator

fmeum commented Jan 18, 2025

Oops, thanks for catching this!

I tested the toolchain type, but I forgot to test that the sh_toolchain forwarding works. Does this cause any concrete issue for you? Would 8.1.0 be timely enough to release this?

@fmeum fmeum requested a review from meteorcloudy January 18, 2025 10:59
@fmeum
Copy link
Collaborator

fmeum commented Jan 18, 2025

@bazel-io fork 8.1.0

@bazel-io bazel-io mentioned this pull request Jan 18, 2025
Open
@BoleynSu
Copy link
Contributor Author

Oops, thanks for catching this!

I tested the toolchain type, but I forgot to test that the sh_toolchain forwarding works. Does this cause any concrete issue for you? Would 8.1.0 be timely enough to release this?

I define my own sh_toolchain so seeing the issue when upgrading to 8.0.1. There is a easy fix, i.e. to use rules_shell instead of bazel_tools so I guess it's not a big issue.

@BoleynSu
Copy link
Contributor Author

BTW, this is also why I asked about hermetic sh_toolchain in the rules_shell repo.

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeum fmeum fmeum approved these changes

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BoleynSu @fmeum @meteorcloudy