Unify implementations of Spawn#getCombinedExecProperties
#24983
+28
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
clean-up-exec-info
branch
2 times, most recently
from
50e5df4 to
ddfe48a
Compare
fmeum
changed the title
Spawn#getCombinedExecProperties
`SimpleSpawn` returned the exec properties of the action owning the spawn, while `BaseSpawn` returned the exec properties of the exec group owning the action that owns the spawn. The latter contains the `exec_properties` set on the target or exec platform, whereas the former is entirely specified by the action.
fmeum
force-pushed
the
clean-up-exec-info
branch
from
ddfe48a to
b1b3bf2
Compare
github-actions
bot
added
team-Performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleSpawnreturned the exec properties of the action owning the spawn, whileBaseSpawnreturned the exec properties of the exec group owning the action that owns the spawn. The latter contains theexec_propertiesset on the target or exec platform, whereas the former is entirely specified by the action.