-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gaddison/spot sdk examples conversion #564
Gaddison/spot sdk examples conversion #564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks great to me! Could you add to the readme with the command to run this example + a short description of what it does?
Also, to get CI to pass, in the repo root run pre-commit install
then pre-commit run --all
and this should fix it.
(you can also follow the steps from the dco log to fix that error: https://github.com/bdaiinstitute/spot_ros2/runs/36316801944)
5eccf8b
to
56168d8
Compare
Three examples - hello_spot, arm_with_body_follow, and wasd - have been added. Next step is to update README. @khughes-bdai , should I also add .md files for each new example? |
Pull Request Test Coverage Report for Build 13208847320Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sure, i think that would be helpful to match the format from the other examples. (it doesn't have to be long, just could be a few sentences explaining what the example does, and maybe link to the original examples from spot sdk for reference?) |
Adding .md's for the three new examples now. |
Added docs (markdowns) for each of the three new behaviors here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Merge activity
|
….ManipulationApiRequestOneOfManipulationCmd.msg
Co-authored-by: Katie Hughes <[email protected]>
Co-authored-by: Katie Hughes <[email protected]>
743dd34
to
3f7facf
Compare
Co-authored-by: Katie Hughes <[email protected]>
Change Overview
Created
hello_spot
in spot_examples to mirror that ofspot-sdk
, as part of SW-1864.Compiled and behavior qualitatively verified on hardware.