Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check dependency close method (#5082) #5084

Merged
merged 3 commits into from
Nov 13, 2024
Merged

fix: check dependency close method (#5082) #5084

merged 3 commits into from
Nov 13, 2024

Conversation

yxtay
Copy link
Contributor

@yxtay yxtay commented Nov 13, 2024

What does this PR address?

  • Adds check for close method in Dependency class
  • Adds tests

Please let me know if the tests need to be adjusted.

Fixes #5082

Before submitting:

@yxtay yxtay requested a review from a team as a code owner November 13, 2024 06:44
@yxtay yxtay requested review from larme and removed request for a team November 13, 2024 06:44
@yxtay
Copy link
Contributor Author

yxtay commented Nov 13, 2024

Hmm, is that a flaky test failure? The code changes definitely did not touch the unit test. Try running the test again?

@frostming frostming merged commit a29f799 into bentoml:main Nov 13, 2024
50 of 51 checks passed
@frostming
Copy link
Contributor

Hmm, is that a flaky test failure? The code changes definitely did not touch the unit test. Try running the test again?

Yes, no worry. Thanks for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: AttributeError: close() called on Service dependency in TestClient
3 participants