feat(metrics): init zero for request count of apis #5186
Merged
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostming
reviewed
Jan 17, 2025
Haivilo
force-pushed
the
init-metric-with-zero
branch
from
5852691 to
b3ffc74
Compare
frostming
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initializes endpoints metrics with 0 request count. This way, doing
rate()in PromQL will correctly capture the rate of change. Currently, if it's the first time an endpoint returns error, metric is incremented to 1, but 0 value is not recorded.rate()will show 0 for error counts. Also imo we don't have to enumerate all http code, which spams the metrics, but we can.