-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-arm recommendation #4297
pre-arm recommendation #4297
Conversation
nerdCopter
commented
Jan 9, 2025
•
edited
Loading
edited
- resolves Default Pre-arm #4280
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@redhonu , would this suffice? |
Quality Gate passedIssues Measures |
I would have preferred a larger warning, but i think this will already help some beginners realize the importance of prearm, for larger quads. |
i was kinda going that route on commit 1 but was asked to move it. |
IMO current change is sufficient. When using suggestion we would have to remove the warning when the pre-enable condition is met 😂 |
There's only so many warnings that can be added without cluttering the UI, a determined-enough user will always find ways to do dangerous things no matter the precautions that are added in the Configurator. I agree that prearm is important, but a tooltip warning is fine for this |
I understand, the tooltip will hopefully already help beginners realize the existence of prearm. |
@nerdCopter is this ready for review / merge ? |