Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-arm recommendation #4297

Merged

Conversation

nerdCopter
Copy link
Member

@nerdCopter nerdCopter commented Jan 9, 2025

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit a48280d
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/677fe8f9373520000807514f
😎 Deploy Preview https://deploy-preview-4297.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nerdCopter
Copy link
Member Author

@redhonu , would this suffice?

Copy link

sonarqubecloud bot commented Jan 9, 2025

@redhonu
Copy link

redhonu commented Jan 9, 2025

I would have preferred a larger warning, but i think this will already help some beginners realize the importance of prearm, for larger quads.

@haslinghuis haslinghuis requested a review from VitroidFPV January 9, 2025 18:00
@redhonu
Copy link

redhonu commented Jan 9, 2025

I am a not a developer, so I'm not sure how to share my suggested changes. Here is what I was imagining:
Screenshot 2025-01-09 195337
These are the changes I made:
Screenshot 2025-01-09 195528

@nerdCopter
Copy link
Member Author

i was kinda going that route on commit 1 but was asked to move it.

@haslinghuis
Copy link
Member

IMO current change is sufficient. When using suggestion we would have to remove the warning when the pre-enable condition is met 😂

@VitroidFPV
Copy link
Member

VitroidFPV commented Jan 9, 2025

There's only so many warnings that can be added without cluttering the UI, a determined-enough user will always find ways to do dangerous things no matter the precautions that are added in the Configurator. I agree that prearm is important, but a tooltip warning is fine for this

@redhonu
Copy link

redhonu commented Jan 10, 2025

I understand, the tooltip will hopefully already help beginners realize the existence of prearm.

@haslinghuis
Copy link
Member

@nerdCopter is this ready for review / merge ?

@nerdCopter nerdCopter marked this pull request as ready for review January 13, 2025 17:47
@haslinghuis haslinghuis merged commit e984e8a into betaflight:master Jan 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Default Pre-arm
5 participants