[DEP][DOC]: 696 fix random seed documentation #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TST: Create unit-tests.yml * TST: try explicit version * TST: Remove unnecessary setup python * TST: disable precommit tests * TST: typo * TST: add pre-commit tests * TST: try installing jupyter for pre-commit * TST: add install/import tests * TST: just install basic version * TST: typo fixes * TST: done run executable tests on windows * TST: another attempt to disable executable tests for windows * TST: remove executable tests * DOC: add documentation job * DOC: make sure to pull tags for docs job * BLD: upload docs as an artifact
…of legacy generator
I realised that pre-commit didn't check any files because there were no logged chagnes. So I ran pre-commit on everything using "pre-commit run --all-files". This only brought up relevant changes from myself, with the exceptions of: "bilby/bilby_mcmc/sampler.py:525:38: E226 missing whitespace around arithmetic operator" which is outside the remit of this merge request.
GregoryAshton
changed the title
|
@GregoryAshton please can you rebase? |
GregoryAshton
changed the title
|
Done @ColmTalbot I'll watch to see if the tests now pass |
ColmTalbot
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Thanks @GregoryAshton! @mj-will and I were talking about this earlier.
I just had one nitpick on whitespace.
Co-authored-by: Colm Talbot <[email protected]>
Co-authored-by: Colm Talbot <[email protected]>
|
@ColmTalbot I don't know where those extra spaces from |
ColmTalbot
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking changes from #25 - I don't have push privileges so just creating a new PR