Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: migration updates #36

Merged
merged 30 commits into from
Oct 7, 2024
Merged

MAINT: migration updates #36

merged 30 commits into from
Oct 7, 2024

Conversation

mj-will
Copy link
Collaborator

@mj-will mj-will commented Sep 17, 2024 •
edited
Loading

Various updates for migration.

This is mostly changes to existing URLs but I've also updated some of the contributing guidelines to point to GitHub rather than GitLab docs

Things that are deferred to a later PR

  • Fixing the coverage badge

@mj-will mj-will requested a review from ColmTalbot September 17, 2024 11:28
ColmTalbot
ColmTalbot requested changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@ColmTalbot ColmTalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments. I also noticed that in the installation instructions it says to pull from git.ligo.org. You may need to also grep for git.ligo.org to make sure there aren't others.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
ColmTalbot
ColmTalbot requested changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@ColmTalbot ColmTalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question and a typo this time!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@ColmTalbot ColmTalbot self-requested a review October 3, 2024 14:22
@ColmTalbot ColmTalbot mentioned this pull request Oct 3, 2024
Open
47 tasks
adivijaykumar
adivijaykumar requested changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@adivijaykumar adivijaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me apart from one small suggestion in the changelog.

CHANGELOG.md Show resolved Hide resolved
@mj-will mj-will force-pushed the migration-updates branch from bae1672 to 5bbf6ee Compare October 4, 2024 15:47
@adivijaykumar adivijaykumar self-requested a review October 7, 2024 13:17
@ColmTalbot
Copy link
Collaborator

I'm going to merge this now so that the docs point to the correct place sooner, but we can correct anything that may have made it through in future changes.

@ColmTalbot ColmTalbot merged commit 84c01e8 into main Oct 7, 2024
10 checks passed
@ColmTalbot ColmTalbot deleted the migration-updates branch October 7, 2024 14:20
@ColmTalbot ColmTalbot mentioned this pull request Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColmTalbot ColmTalbot ColmTalbot approved these changes

@adivijaykumar adivijaykumar adivijaykumar approved these changes

@GregoryAshton GregoryAshton Awaiting requested review from GregoryAshton

@asb5468 asb5468 Awaiting requested review from asb5468

Assignees
No one assigned
Labels
github migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mj-will @ColmTalbot @adivijaykumar