Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Example of a bad PR - do not merge! #50

Closed
wants to merge 1 commit into from

Conversation

luanpotter
Copy link
Member

This is an example of a bad PR that introduces unnecessary latency - let's see if the benchmarks are up to the task!

@coveralls
Copy link

coveralls commented Dec 23, 2024

Pull Request Test Coverage Report for Build 12613660775

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 97.436%

Totals Coverage Status
Change from base Build 12606197886: 0.09%
Covered Lines: 114
Relevant Lines: 117

💛 - Coveralls

Copy link

github-actions bot commented Jan 4, 2025

Benchmark Results

Package ordered_set:

Benchmarks Current Branch
[luan.do-not-merge]
Base Branch
[main]
Diff
Iteration Benchmark 265.356 μs 249.971 μs 🔴 +6.154 %
Insertion and Removal Benchmark 56454.629 μs 338.352 μs 🔴 +16585.175 %
Comprehensive Benchmark 106863.941 μs 15675.527 μs 🔴 +581.725 %

Benchmarks provided with 💙 by Dart Benchmark Action.

@luanpotter
Copy link
Member Author

This serves as a great example.

@luanpotter luanpotter closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants