Added depth and pressure, updated README #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I have used the C++ version of this KellerLD module that is used for microcontrollers:
https://github.com/bluerobotics/BlueRobotics_KellerLD_Library/
That library features calculations to convert the pressure obtained from the sensor to Depth and Altitude readings. I was hoping this feature could be added to this module, as we were utilizing this python module for use with Jetson Nano's, which have a GPIO pinout to read in the values from the BlueRobotics sensor.
I made modifications to the code, and tried to keep similar naming conventions / styles to that of your Python setup, as well to reference the way you have does the calculations in the C++ version of this module.
Things that were added/changed:
The modified code was tested on a Jetson Nano (by running the modified example.py script, and changing the pressure units) and seems to perform as expected.
I'm open to suggestions / changes to better match your formatting preference, but figured this would be useful for people in the future so they do not have to do their own conversions / calculations, especially if they are in a situation like me where they migrate from the functionality in the C++ microcontroller module, to this Python version.
-Raymond