Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposed lexicons for mod report routing #3521
base: main
Are you sure you want to change the base?
proposed lexicons for mod report routing #3521
Changes from 2 commits
9284d68
668f592
b012a4a
94a1ab5
f86586f
9e638db
c85bd2d
272c959
9d6f78f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing
(example reason)
is coming later :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is meant by that is the Bluesky Moderation Service won't declare or handle this reason. It is included as an example that such reasons can exist (eg, that the reason set isn't strictly 1-to-1 with bsky mod service policies, even if the "known" ones like up for the near future)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that makes sense 👍
Sorry about the tone of my comment being a little weird btw, I shouldn't have been up so late.
I really appreciate all the work you and the rest of the team are putting in to make the moderation experience better 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a gut check— will this default be a breaking change for anyone? E.g. anyone labeling lists, feedgens, etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe anybody is labeling those things other than us (bsky mod team). I will update to "[...] default is any record type" to be safe though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to be used anywhere? I'm guessing the incoming report would set this or are we going to infer from the subject itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the client app would use this to decide which subscribed labelers are in-scope for any particular report. it is declared in
app.bsky.labeler.service
. same withsubjectCollections
(array of NSIDs).neither need to be included in reports because the subject type (DID vs strongRef-with-ATURI) contains the same info.