agnostic: default putRecord to not include swapRecord field #935
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root issue here is "nullable and optional" not being easy to express with default golang struct marshaling. The result is this swap field getting set, but as null, which prevents actual updates (only allows creation). This PR swaps to omitting the field. Makes it impossible to do a forced swap check of nil... but can just use create for that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root issue here is "nullable and optional" not being easy to express with default golang struct marshaling. The result is this swap field getting set, but as null, which prevents actual updates (only allows creation).
This PR swaps to omitting the field. Makes it impossible to do a forced swap check of nil... but can just use create for that?