Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building Boost.Build with a chosen toolset #690

Closed
wants to merge 1 commit into from

Conversation

amyspark
Copy link

👋

Hi! This PR proposes to upstream a small change that we are shipping in Krita starting with 5.1 (https://invent.kde.org/graphics/krita/-/commit/2876937bf2dfea45645c31ebb749b1a0d08d067b).

In short, this will enable users of the CMD bootstrap file to build Boost with a toolset other than MSVC. We use it in particular to target the llvm-mingw compiler, through a custom user-config.jam. (It also applies to the official MSYS2 CLANG* flavours, which I use for my own personal development needs.)

cc @dimula73

@mclow
Copy link
Contributor

mclow commented Oct 4, 2022

This looks very similar to #682

@amyspark
Copy link
Author

amyspark commented Oct 6, 2022

That's correct @mclow. However, the other PR neither is documented nor does it specify the rationale for the proposed change, so that's why I didn't spot it before submitting this one.

@amyspark
Copy link
Author

@mclow I see there's a window open for bugfixes, would it be possible for this to get reviewed?

@swatanabe
Copy link
Contributor

swatanabe commented Nov 25, 2022 via email

@amyspark
Copy link
Author

Ok, closing this one in favour of #513.

@amyspark amyspark closed this Nov 27, 2022
@amyspark amyspark deleted the amyspark/krita branch November 27, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants