Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Boost.Assign usages. #416

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove Boost.Assign usages. #416

wants to merge 1 commit into from

Conversation

gogagum
Copy link

@gogagum gogagum commented Feb 5, 2025 •
edited
Loading

Boost.Assign is not needed C++14 code. This PR removes this library usages. It is also suggested to use std::vector std::initializer_list constructor instead of series of push_back calls in test/two_graphs_common_spanning_trees_test.cpp.

jeremy-murphy
jeremy-murphy approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@jeremy-murphy jeremy-murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a tidy improvement to the code! Just waiting for the tests to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremy-murphy jeremy-murphy jeremy-murphy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gogagum @jeremy-murphy