Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "patch" to verbs for namespace-scoped CRDs in namespace_scoped.yaml #372

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

anfredette
Copy link
Contributor

This allows the user to update the CRDs.

This allows the user to update the CRDs.

Signed-off-by: Andre Fredette <[email protected]>
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.12%. Comparing base (fc76814) to head (7a20a1d).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   28.12%   28.12%           
=======================================
  Files         128      128           
  Lines       11207    11207           
=======================================
  Hits         3152     3152           
  Misses       7773     7773           
  Partials      282      282           
Flag Coverage Δ
unittests 28.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msherif1234
Copy link
Contributor

@anfredette
Copy link
Contributor Author

don't u need to add it https://github.com/bpfman/bpfman-operator/blob/main/config/rbac/bpfman-agent/role.yaml and https://github.com/bpfman/bpfman-operator/blob/main/config/rbac/bpfman-operator/role.yaml

then run make manifests bundle

I could be wrong, but I didn't think so. This file is used for testing the namespace-scoped CRDs. It's used to create a ServiceAccount that can apply the namespace-scoped CRDs in a particular namespace. Billy has some instructions for using it, but I don't know if they've been pushed or merged yet.

@Billy99 what do you think?

@Billy99
Copy link
Contributor

Billy99 commented Feb 11, 2025

https://github.com/bpfman/bpfman-operator/blob/main/config/rbac/bpfman-agent/role.yaml and https://github.com/bpfman/bpfman-operator/blob/main/config/rbac/bpfman-operator/role.yaml are generated files and already have patch in them. This is a yaml file used for testing Namespace Scoped CRDs and is standalone.

@Billy99
Copy link
Contributor

Billy99 commented Feb 11, 2025

Copy link
Contributor

@Billy99 Billy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mergify mergify bot merged commit 18cf445 into bpfman:main Feb 11, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants