-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS support #23
CORS support #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there,
Sorry for taking so long to review this! 😬
If you're still eager to contribute, I required some minor changes.
Thanks a lot!
Ben
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 138 152 +14
===========================================
Files 25 27 +2
Lines 396 439 +43
===========================================
+ Hits 396 439 +43 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @domino91, thanks for getting back on this.
Can you please fix CI (composer linter:fix
) and add an integration test?
You could try to issue a GET request to /.well-known/mercure
without any topic: it should respond with a 400 Bad Request
and you're supposed to see CORS headers in the response.
Some LOC remain uncovered: https://app.codecov.io/gh/bpolaszek/freddie/pull/23/blob/src/Hub/Middleware/CorsMiddleware.php
Thanks!
Thank you @domino91 👍 |
No description provided.