Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS support #23

Merged
merged 4 commits into from
Nov 5, 2024
Merged

CORS support #23

merged 4 commits into from
Nov 5, 2024

Conversation

domino91
Copy link
Contributor

@domino91 domino91 commented Jul 4, 2023

No description provided.

Copy link
Owner

@bpolaszek bpolaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there,

Sorry for taking so long to review this! 😬
If you're still eager to contribute, I required some minor changes.

Thanks a lot!
Ben

src/Hub/Middleware/CorsMiddleware.php Outdated Show resolved Hide resolved
src/Hub/Middleware/CorsMiddleware.php Show resolved Hide resolved
src/Hub/Middleware/CorsMiddleware.php Show resolved Hide resolved
@domino91 domino91 requested a review from bpolaszek October 14, 2024 14:52
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6fc70c7) to head (b56697e).
Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##                main       #23   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       138       152   +14     
===========================================
  Files             25        27    +2     
  Lines            396       439   +43     
===========================================
+ Hits             396       439   +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@bpolaszek bpolaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @domino91, thanks for getting back on this.
Can you please fix CI (composer linter:fix) and add an integration test?
You could try to issue a GET request to /.well-known/mercure without any topic: it should respond with a 400 Bad Request and you're supposed to see CORS headers in the response.

Some LOC remain uncovered: https://app.codecov.io/gh/bpolaszek/freddie/pull/23/blob/src/Hub/Middleware/CorsMiddleware.php

Thanks!

@domino91 domino91 requested a review from bpolaszek November 1, 2024 15:41
@bpolaszek bpolaszek merged commit b3e0d3f into bpolaszek:main Nov 5, 2024
20 checks passed
@bpolaszek
Copy link
Owner

Thank you @domino91 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants