feat: add check digit validation for aba routing numbers #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlickey
force-pushed
the
feat/checkdigit-validation
branch
from
6d385e0 to
da0b937
Compare
phlickey
force-pushed
the
feat/checkdigit-validation
branch
from
da0b937 to
a0ffbf0
Compare
|
Hey @phlickey , thanks for the PR! We've added a ticket to review and add feedback in our upcoming sprint. For internal tracking -> DTBTSDK-2900 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements check digit validation according to the algorithm described here:
https://en.wikipedia.org/wiki/ABA_routing_transit_number#Check_digit
It assigns the result to the
isPotentiallyValidproperty of the validation result, so as not to introduce a breaking change.An additional property,
isCheckDigitValidcould also be added to further disambiguate the check, since this is definitely less permissive than the existingisPotentiallyValidresult.