-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logo to README #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best practice is to use lowercase filenames with no spaces
Also the logo is way too big.
You can use a "-" in the filename instead of spaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You now have two logo files
I see now I have multiple '.png' assets. Should I resize the image or use an HTML Exception? |
Let us keep the current image size and use HTML width 150. I want to work on this after you are finished. Another PR for me. We can always change it later. Let us see |
Is there anything else I need to do in order to close out my first PR on this topic? This is my first so bear with me. 2 uncussessful checks: The configuration file (path: .github/labeler.yml) was not found locally, fetching via the api |
Thank you 👍 |
Hey @TylrDn well done. I sent you an invite to join the Brisbane Social Chess GitHub organization. It is safe to join and we invite all contributors. Thanks once again 👍 |
Added a new logo image and updated the README to include it at the top.