Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo to README #59

Merged
merged 9 commits into from
Oct 27, 2024
Merged

Add logo to README #59

merged 9 commits into from
Oct 27, 2024

Conversation

TylrDn
Copy link
Contributor

@TylrDn TylrDn commented Oct 27, 2024

Added a new logo image and updated the README to include it at the top.

@TylrDn TylrDn requested a review from jbampton as a code owner October 27, 2024 20:02
@jbampton jbampton self-assigned this Oct 27, 2024
@jbampton jbampton added documentation Improvements or additions to documentation good first issue Good for newcomers labels Oct 27, 2024
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best practice is to use lowercase filenames with no spaces

Also the logo is way too big.

@jbampton
Copy link
Member

You can use a "-" in the filename instead of spaces

@jbampton jbampton marked this pull request as draft October 27, 2024 20:10
@TylrDn TylrDn marked this pull request as ready for review October 27, 2024 20:17
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You now have two logo files

@TylrDn
Copy link
Contributor Author

TylrDn commented Oct 27, 2024

I see now I have multiple '.png' assets. Should I resize the image or use an HTML Exception?

@jbampton
Copy link
Member

Let us keep the current image size and use HTML width 150.

I want to work on this after you are finished. Another PR for me.

We can always change it later. Let us see

@TylrDn
Copy link
Contributor Author

TylrDn commented Oct 27, 2024

Is there anything else I need to do in order to close out my first PR on this topic?

This is my first so bear with me. 2 uncussessful checks:

The configuration file (path: .github/labeler.yml) was not found locally, fetching via the api
Error: Error: found unexpected type for label 'documentation' (should be array of config options)
Error: found unexpected type for label 'documentation' (should be array of config options)

.github/labeler.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jbampton jbampton merged commit 446999d into brisbanesocialchess:main Oct 27, 2024
1 of 2 checks passed
@jbampton
Copy link
Member

Thank you 👍

@TylrDn TylrDn deleted the add-logo branch October 27, 2024 21:01
@jbampton
Copy link
Member

Hey @TylrDn well done.

I sent you an invite to join the Brisbane Social Chess GitHub organization.

It is safe to join and we invite all contributors. Thanks once again 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest hacktoberfest-accepted
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add our new logo to the README We need a new awesome social chess logo
2 participants