Generally avoid add/.add argument of dplyr

R/collapse_index.R

@@ -66,7 +66,7 @@
 #' # calculate monthly standard deviation for each column
 #' FANG %>%
 #'   dplyr::mutate(date = collapse_index(date, "monthly")) %>%
-#'   dplyr::group_by(date, add = TRUE) %>%
+#'   dplyr::group_by(symbol, date) %>%
 #'   dplyr::summarise_all(sd)
 #'
 #'
@@ -178,7 +178,7 @@ collapse_index <- function(index, period = "yearly",
 #' # calculate monthly standard deviation for each column
 #' FANG %>%
 #'   collapse_by("monthly") %>%
-#'   dplyr::group_by(date, add = TRUE) %>%
+#'   dplyr::group_by(symbol, date) %>%
 #'   dplyr::summarise_all(sd)
 #'
 #' @export

README.Rmd

@@ -173,7 +173,7 @@ FANG %>%
   collapse_by("year") %>%
   
   # Additionally group by date (yearly)
-  group_by(date, add = TRUE) %>%
+  group_by(symbol, date) %>%
   
   # Perform a yearly summary for each symbol
   summarise(

README.md

@@ -258,18 +258,14 @@ FANG %>%
   collapse_by("year") %>%
 
   # Additionally group by date (yearly)
-  group_by(date, add = TRUE) %>%
+  group_by(symbol, date) %>%
 
   # Perform a yearly summary for each symbol
   summarise(
     adj_min   = min(adjusted),
     adj_max   = max(adjusted),
     adj_range = adj_max - adj_min
   )
-#> Warning: The `add` argument of `group_by()` is deprecated as of dplyr 1.0.0.
-#> Please use the `.add` argument instead.
-#> This warning is displayed once every 8 hours.
-#> Call `lifecycle::last_warnings()` to see where this warning was generated.
 #> `summarise()` regrouping output by 'symbol' (override with `.groups` argument)
 #> # A time tibble: 16 x 5
 #> # Index:  date

vignettes/TT-04-use-with-dplyr.Rmd

@@ -104,7 +104,7 @@ price_series <- bind_rows(list(apple = apple, facebook = facebook), .id = "symbo
 # common financial transformation
 price_series %>%
   collapse_by("daily") %>%
-  group_by(date, add = TRUE) %>%
+  group_by(symbol, date) %>%
   summarise(
     open  = first(price),
     high  = max(price),