Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Elixir 1.7 for OTP 21 #95

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Build Elixir 1.7 for OTP 21 #95

merged 1 commit into from
Oct 25, 2018

Conversation

maennchen
Copy link
Contributor

Build Elixir release manually until hexpm/bob#17 is ready.

Temporary fix for #90.

@c0b
Copy link
Owner

c0b commented Oct 18, 2018

Looks good

@andresgutgon
Copy link

Can this be merged?

@c0b
Copy link
Owner

c0b commented Oct 22, 2018

right, the hexpm/bob#17 seems won't be ready very soon

while if merge this right now and push to official elixir:v1.7* there might be a shock to those already using elixir:v1.7* images in production, I don't have a number how many of those will be affected, and most probably no impact as well, but need to be careful because when we blindly upgrade elixir:v1.6 image to be from erlang:20 upgrade to erlang:21 that caused some problems to those who trusted to write like FROM elixir:v1.6 as base image
this ALL depends on how different is made by this change, from a min-erlang version Precompiled.zip to a source based builds may be; Let's do some more testing

@maennchen
Copy link
Contributor Author

@c0b There should be no change for existing users except that dialyzer actually works. Otherwise the images are identical.

@maennchen
Copy link
Contributor Author

(exactly the same Elixir & Erlang version, this should not affect any users in production)

@c0b c0b merged commit 1df5c52 into c0b:master Oct 25, 2018
@maennchen maennchen deleted the fix_1.7_otp_21 branch October 25, 2018 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants