Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use already downloaded bundle #955

Merged
merged 4 commits into from
Feb 9, 2025

Conversation

hosseinmd
Copy link
Contributor

@hosseinmd hosseinmd commented Feb 5, 2025

if an script doesn't cached the steps to run it is download, write, read, run
there is no need to read it again,
This changes will improve performance.

Summary

Test plan

Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: f4a485c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@callstack/repack Patch
@callstack/repack-plugin-reanimated Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 7:04pm

@hosseinmd hosseinmd changed the title fix: use already existing bundle fix: use already downloaded bundle Feb 7, 2025
@hosseinmd
Copy link
Contributor Author

@jbroma please review

Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Very nice find, thank you @hosseinmd!

@jbroma jbroma merged commit 49b8ddf into callstack:main Feb 9, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants