fix!: use correct representation of Coding object in mappings #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close #220 * `system` MUST use `iriReference`, not a free-text label * `code` MUST use syntax defined by the `system` * `id` will use record `concept_id`
korikuzma
added
priority:medium
korikuzma
commented
Jan 20, 2025
korikuzma
commented
Jan 20, 2025
jsstevenson
requested changes
Jan 22, 2025
korikuzma
requested review from
jsstevenson
and removed request for
jsstevenson
3 tasks
|
This PR is stale because it has been open 3 day(s) with no activity. Please review this PR. |
|
Meeting with Alex tomorrow to discuss this |
|
@jsstevenson looks like the MONDO changes are already in. Ready for your re-review |
jsstevenson
previously approved these changes
Jan 28, 2025
jsstevenson
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #220
CodingrepresentationsystemMUST useiriReference, not a free-text labelcodeMUST use syntax defined by thesystemidwill use recordconcept_idNAMESPACE_TO_SYSTEM_URIis now aMappingProxyTypeSYSTEM_URI_TO_NAMESPACEmapping (since it's no longer needed)NamespacePrefixmembers (if needed, will be added back inNamespacePrefixcontains external sources that we don't capture #214):COHD,DECIPHER,HP,HPO,ICD9,ICD11,IDO,MF,MP,MPATH,NIFSTD,OBI,OGMS,PATO,SCDO,WIKIPEDIA,WIKIDATA