Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: update models to ga4gh gks nov 2024 ballot releases #420

Draft
wants to merge 18 commits into
base: staging
Choose a base branch
from
Draft

feat!: update models to ga4gh gks nov 2024 ballot releases #420

wants to merge 18 commits into from

Conversation

korikuzma
Copy link
Member

@korikuzma korikuzma commented Jan 21, 2025 •
edited
Loading

Marking this as medium priority, since I can work locally for now. But this is required for VarCat MVP / ClinVar submission.

close #415

Changes:

  • Update vicc normalizers and ga4gh gks versions to point to latest ballot releases
    • This also updates transformers to use correct representations with these new models
  • Therapeutic Procedure / Agent --> Therapy rename to align with GKS

Comments:

  • In a previous version, we created Proposition nodes in the database. Since we need to get something out ASAP, I did not create these. If needed in the future, we can create a new issue.
  • CIViC was generated used the cache here

Still todo before opening/merging:

  • Use VA Spec pypi package (once made)

@korikuzma korikuzma added enhancement New feature or request priority:medium Medium priority labels Jan 21, 2025
@korikuzma korikuzma self-assigned this Jan 21, 2025
@korikuzma
Copy link
Member Author

@katiestahl @mcannon068nw This is ready for review. Keeping as draft so I don't forget to change deps to use VA Spec pypi package

@korikuzma korikuzma changed the base branch from staging to resolve-ruff January 24, 2025 15:50
Base automatically changed from resolve-ruff to staging January 24, 2025 16:21
@korikuzma korikuzma mentioned this pull request Jan 26, 2025
Draft
@korikuzma korikuzma linked an issue Jan 27, 2025 that may be closed by this pull request
Update transformers to use the Nov 2024 ballot releases #415
Open
@korikuzma korikuzma mentioned this pull request Jan 27, 2025
Draft
mcannon068nw
mcannon068nw approved these changes Jan 28, 2025
View reviewed changes
Copy link

@mcannon068nw mcannon068nw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

katiestahl
katiestahl approved these changes Feb 4, 2025
View reviewed changes
Copy link

@katiestahl katiestahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so sorry, thought I had approved this a while ago. I think I forgot to hit submit. Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katiestahl katiestahl katiestahl approved these changes

@mcannon068nw mcannon068nw mcannon068nw approved these changes

Assignees

@korikuzma korikuzma

Labels
enhancement New feature or request priority:medium Medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update transformers to use the Nov 2024 ballot releases
3 participants
@korikuzma @katiestahl @mcannon068nw