fix(button): change prop dangerDescriptor to dangerDescription #18302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18302 +/- ##
==========================================
- Coverage 84.17% 84.16% -0.01%
==========================================
Files 408 408
Lines 14435 14449 +14
Branches 4690 4696 +6
==========================================
+ Hits 12150 12161 +11
- Misses 2121 2123 +2
- Partials 164 165 +1 ☔ View full report in Codecov by Sentry. |
2nikhiltom
approved these changes
Jan 8, 2025
tay1orjones
requested review from
a team and
laurenmrice
and removed request for
a team
|
Hey, thanks for putting up this PR! I just added @laurenmrice as a reviewer to be sure we get a ux and visual review on this. |
laurenmrice
approved these changes
Jan 21, 2025
guidari
approved these changes
Jan 28, 2025
kennylam
approved these changes
Jan 29, 2025
auto-merge was automatically disabled
January 29, 2025 16:05
Pull Request is not mergeable
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
via the queue into
carbon-design-system:main
with commit Jan 30, 2025
1e1bc22
37 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17922
Parity: Button
Changelog
packages/web-components/src/components/button/button.tsChanged
dangerDescriptortodangerDescriptionTesting / Reviewing
dangerDescriptiondangerDescriptionvalue you've given in the prop