-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update accessibility-checker to 3.1.79 and turns rules on #18317
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18317 +/- ##
=======================================
Coverage 84.16% 84.16%
=======================================
Files 408 408
Lines 14449 14449
Branches 4700 4646 -54
=======================================
Hits 12161 12161
- Misses 2123 2124 +1
+ Partials 165 164 -1 ☔ View full report in Codecov by Sentry. |
@2nikhiltom could you share specifically what a11y rule this fixes and why? This will be a spec change for the component that we'll need to populate everywhere. I'm curious if there's anything else we could try to avoid a spec change? @laurenmrice here's the visual diff for this |
@tay1orjones Thanks Taylor. @2nikhiltom If possible we should avoid this spec change. The design specs should stay as is. |
@tay1orjones The issue is happening in
I feel one way to fix this without modifying the component source or styles is to wrap the Toggletip in a semantic |
Closes #18227
Update accessibility-checker to 3.1.79
Turns on
label_name_visible,
aria_attribute_conflict
and target_spacing_sufficient
rules back on inside 'toHaveNoACViolations' of both playwright and jest configsMade changes in SCSS styles to accommodate the fix for a11y violations
Changelog
Changed
Testing / Reviewing
Verify no ci failures
Verify no a11y violations
Verify if the styles changes are acceptable