Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): resolve descrepancy in close button aria-label prop #18383

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

makafsal
Copy link
Member

@makafsal makafsal commented Jan 20, 2025

Closes #17930

{{short description}}

Changelog

Changed

  • Changed prop close-button-assistive-text to close-button-label-text

Testing / Reviewing

  1. Turn on screen reader
  2. Open search component storybook
  3. Using the tab key focus the close button
  4. Expect the close-button-label-text is announced

@makafsal makafsal requested a review from a team as a code owner January 20, 2025 07:39
@makafsal makafsal requested review from kennylam and emyarod January 20, 2025 07:39
Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit cc7beb1
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/678dfdbbbd943c00080f0d88
😎 Deploy Preview https://deploy-preview-18383--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit cc7beb1
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/678dfdbb7553800007ba425e
😎 Deploy Preview https://deploy-preview-18383--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cc7beb1
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/678dfdbb89ea930008c79013
😎 Deploy Preview https://deploy-preview-18383--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (0c2ff15) to head (cc7beb1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18383   +/-   ##
=======================================
  Coverage   84.17%   84.17%           
=======================================
  Files         408      408           
  Lines       14435    14435           
  Branches     4660     4690   +30     
=======================================
  Hits        12150    12150           
- Misses       2120     2121    +1     
+ Partials      165      164    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React|WC Parity: Search
1 participant