Model the return slot as an output parameter #4432
Conversation
toolchain/sem_ir/typed_insts.h
Outdated
| TypeId type_id; | ||
| InstId value_id; |
There was a problem hiding this comment.
Comment? I'm guessing type_id matches the return type of the function (though it might be good to separately associate the specific instruction representing that expression in the source for diagnostics). What is the value_id?
There was a problem hiding this comment.
OK, how's this?
(though it might be good to separately associate the specific instruction representing that expression in the source for diagnostics)
Do you see any places we can use that right now? If not, I'd rather wait until we have a need for it.
toolchain/check/return.cpp
Outdated
| @@ -42,7 +42,7 @@ static auto NoteReturnType(Context::DiagnosticBuilder& diag, | |||
| SemIR::TypeId return_type_id) { | |||
| CARBON_DIAGNOSTIC(ReturnTypeHereNote, Note, "return type of function is {0}", | |||
| SemIR::TypeId); | |||
| diag.Note(function.return_storage_id, ReturnTypeHereNote, return_type_id); | |||
| diag.Note(function.return_slot_id, ReturnTypeHereNote, return_type_id); | |||
There was a problem hiding this comment.
Here is an example where it would be better to use an instruction id instead of a TypeId, so that we could match the spelling of the type the user wrote. We have been using TypeIds previously, but the goal is to switch.
There was a problem hiding this comment.
OK, given an InstId representing the type expression the user wrote, how do I obtain the spelling the user wrote? Is there an existing example of the new pattern that I can follow to update this code?
There was a problem hiding this comment.
Use the type InstIdAsType as the type of the diagnostic argument; search for that type name for examples.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Also fix
Paraminsts to have meaningful names in pretty-printing, to help clarify relationship with return slot.