Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Context::IsImplFile to File::is_impl #4931

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Feb 12, 2025

Note this mirrors parse_tree().packaging_decl().is_impl, but I'm preferring to keep the version that doesn't access the parse tree so that we could change tree storage without hurting as much.

Copy link
Contributor

@danakj danakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonmeow jonmeow enabled auto-merge February 12, 2025 18:25
@jonmeow jonmeow added this pull request to the merge queue Feb 12, 2025
Merged via the queue into carbon-language:trunk with commit 8af64ce Feb 12, 2025
8 checks passed
@jonmeow jonmeow deleted the is-impl branch February 12, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants