Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add recipient module #1377

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

✨ Add recipient module #1377

wants to merge 13 commits into from

Conversation

bal7hazar
Copy link
Contributor

@bal7hazar bal7hazar commented Feb 6, 2025

image

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui-next ✅ Ready (Inspect) Visit Preview Feb 7, 2025 5:20pm

Copy link
Contributor

github-actions bot commented Feb 6, 2025

🎨 Visual Regression Test Results

✅ No visual changes detected

Copy link
Contributor

github-actions bot commented Feb 7, 2025

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 ui-next

🔄 Snapshot Updates in PR

The following snapshots have been updated in this PR:

  • icons--brand-chromium
  • modules-amount--negative-amount-chromium
  • modules-amount--zero-decimals-chromium
  • modules-recipient--argent-confirmed-chromium
  • modules-recipient--argent-named-selection-chromium
  • modules-recipient--argent-preview-chromium
  • modules-recipient--argent-unamed-selection-chromium
  • modules-recipient--argent-validated-chromium
  • modules-recipient--braavos-named-selection-chromium
  • modules-recipient--braavos-preview-chromium
  • modules-recipient--braavos-unamed-selection-chromium
  • modules-recipient--controller-confirmed-chromium
  • modules-recipient--controller-named-selection-chromium
  • modules-recipient--controller-preview-chromium
  • modules-recipient--controller-validated-chromium
  • modules-recipient--default-chromium
  • modules-recipient--error-chromium
  • modules-recipient--open-zeppelin-preview-chromium
  • modules-recipient--openzeppelin-named-selection-chromium
  • modules-recipient--openzeppelin-unamed-selection-chromium
  • modules-recipient--wallet-named-selection-chromium
  • modules-recipient--wallet-preview-chromium
  • modules-recipient--wallet-unamed-selection-chromium
  • textarea--default-chromium

📦 profile

🔄 Snapshot Updates in PR

The following snapshots have been updated in this PR:

  • components-inventory-collection-send--default-chromium
  • components-inventory-token-send--default-chromium
🖼️ View All Image Changes

ui-next - icons--brand-chromium

icons--brand-chromium

ui-next - modules-amount--negative-amount-chromium

modules-amount--negative-amount-chromium

ui-next - modules-amount--zero-decimals-chromium

modules-amount--zero-decimals-chromium

ui-next - modules-recipient--argent-confirmed-chromium

modules-recipient--argent-confirmed-chromium

ui-next - modules-recipient--argent-named-selection-chromium

modules-recipient--argent-named-selection-chromium

ui-next - modules-recipient--argent-preview-chromium

modules-recipient--argent-preview-chromium

ui-next - modules-recipient--argent-unamed-selection-chromium

modules-recipient--argent-unamed-selection-chromium

ui-next - modules-recipient--argent-validated-chromium

modules-recipient--argent-validated-chromium

ui-next - modules-recipient--braavos-named-selection-chromium

modules-recipient--braavos-named-selection-chromium

ui-next - modules-recipient--braavos-preview-chromium

modules-recipient--braavos-preview-chromium

ui-next - modules-recipient--braavos-unamed-selection-chromium

modules-recipient--braavos-unamed-selection-chromium

ui-next - modules-recipient--controller-confirmed-chromium

modules-recipient--controller-confirmed-chromium

ui-next - modules-recipient--controller-named-selection-chromium

modules-recipient--controller-named-selection-chromium

ui-next - modules-recipient--controller-preview-chromium

modules-recipient--controller-preview-chromium

ui-next - modules-recipient--controller-validated-chromium

modules-recipient--controller-validated-chromium

ui-next - modules-recipient--default-chromium

modules-recipient--default-chromium

ui-next - modules-recipient--error-chromium

modules-recipient--error-chromium

ui-next - modules-recipient--open-zeppelin-preview-chromium

modules-recipient--open-zeppelin-preview-chromium

ui-next - modules-recipient--openzeppelin-named-selection-chromium

modules-recipient--openzeppelin-named-selection-chromium

ui-next - modules-recipient--openzeppelin-unamed-selection-chromium

modules-recipient--openzeppelin-unamed-selection-chromium

ui-next - modules-recipient--wallet-named-selection-chromium

modules-recipient--wallet-named-selection-chromium

ui-next - modules-recipient--wallet-preview-chromium

modules-recipient--wallet-preview-chromium

ui-next - modules-recipient--wallet-unamed-selection-chromium

modules-recipient--wallet-unamed-selection-chromium

ui-next - textarea--default-chromium

textarea--default-chromium

profile - components-inventory-collection-send--default-chromium

components-inventory-collection-send--default-chromium

profile - components-inventory-token-send--default-chromium

components-inventory-token-send--default-chromium

@tarrencev
Copy link
Contributor

image

Can we hide the x if the input is empty? Additionally, lets make the placeholder Recipient Address or Username

image
Can we improve the wrapping here?

@bal7hazar
Copy link
Contributor Author

bal7hazar commented Feb 7, 2025

@tarrencev

Can we hide the x if the input is empty? Additionally, lets make the placeholder Recipient Address or Username

image

Can we improve the wrapping here?

I have turned the font from sans to mono to avoid unexpected wrapping
A normal formatted Starknet address should take exactly 2 lines

image
image
image

And more for unexpected longer string

image

Copy link
Contributor

github-actions bot commented Feb 7, 2025

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 ui-next

🔄 Snapshot Updates in PR

The following snapshots have been updated in this PR:

  • button--default-chromium
  • button--disabled-chromium
  • button--ghost-chromium
  • button--medium-chromium
  • button--outline-chromium
  • button--secondary-chromium
  • button--with-icon-chromium
  • icons--brand-chromium
  • modules-amount--negative-amount-chromium
  • modules-amount--zero-decimals-chromium
  • modules-recipient--argent-confirmed-chromium
  • modules-recipient--argent-named-selection-chromium
  • modules-recipient--argent-preview-chromium
  • modules-recipient--argent-unamed-selection-chromium
  • modules-recipient--argent-validated-chromium
  • modules-recipient--braavos-named-selection-chromium
  • modules-recipient--braavos-preview-chromium
  • modules-recipient--braavos-unamed-selection-chromium
  • modules-recipient--controller-confirmed-chromium
  • modules-recipient--controller-named-selection-chromium
  • modules-recipient--controller-preview-chromium
  • modules-recipient--controller-validated-chromium
  • modules-recipient--default-chromium
  • modules-recipient--error-chromium
  • modules-recipient--open-zeppelin-preview-chromium
  • modules-recipient--openzeppelin-named-selection-chromium
  • modules-recipient--openzeppelin-unamed-selection-chromium
  • modules-recipient--wallet-named-selection-chromium
  • modules-recipient--wallet-preview-chromium
  • modules-recipient--wallet-unamed-selection-chromium
  • network--mainnet-chromium
  • network--sepolia-chromium
  • network--slot-chromium
  • network--unknown-chromium
  • textarea--default-chromium
  • toast--default-chromium

📦 profile

🔄 Snapshot Updates in PR

The following snapshots have been updated in this PR:

  • components-inventory-collection-send--default-chromium
  • components-inventory-token-send--default-chromium
🖼️ View All Image Changes

ui-next - button--default-chromium

button--default-chromium

ui-next - button--disabled-chromium

button--disabled-chromium

ui-next - button--ghost-chromium

button--ghost-chromium

ui-next - button--medium-chromium

button--medium-chromium

ui-next - button--outline-chromium

button--outline-chromium

ui-next - button--secondary-chromium

button--secondary-chromium

ui-next - button--with-icon-chromium

button--with-icon-chromium

ui-next - icons--brand-chromium

icons--brand-chromium

ui-next - modules-amount--negative-amount-chromium

modules-amount--negative-amount-chromium

ui-next - modules-amount--zero-decimals-chromium

modules-amount--zero-decimals-chromium

ui-next - modules-recipient--argent-confirmed-chromium

modules-recipient--argent-confirmed-chromium

ui-next - modules-recipient--argent-named-selection-chromium

modules-recipient--argent-named-selection-chromium

ui-next - modules-recipient--argent-preview-chromium

modules-recipient--argent-preview-chromium

ui-next - modules-recipient--argent-unamed-selection-chromium

modules-recipient--argent-unamed-selection-chromium

ui-next - modules-recipient--argent-validated-chromium

modules-recipient--argent-validated-chromium

ui-next - modules-recipient--braavos-named-selection-chromium

modules-recipient--braavos-named-selection-chromium

ui-next - modules-recipient--braavos-preview-chromium

modules-recipient--braavos-preview-chromium

ui-next - modules-recipient--braavos-unamed-selection-chromium

modules-recipient--braavos-unamed-selection-chromium

ui-next - modules-recipient--controller-confirmed-chromium

modules-recipient--controller-confirmed-chromium

ui-next - modules-recipient--controller-named-selection-chromium

modules-recipient--controller-named-selection-chromium

ui-next - modules-recipient--controller-preview-chromium

modules-recipient--controller-preview-chromium

ui-next - modules-recipient--controller-validated-chromium

modules-recipient--controller-validated-chromium

ui-next - modules-recipient--default-chromium

modules-recipient--default-chromium

ui-next - modules-recipient--error-chromium

modules-recipient--error-chromium

ui-next - modules-recipient--open-zeppelin-preview-chromium

modules-recipient--open-zeppelin-preview-chromium

ui-next - modules-recipient--openzeppelin-named-selection-chromium

modules-recipient--openzeppelin-named-selection-chromium

ui-next - modules-recipient--openzeppelin-unamed-selection-chromium

modules-recipient--openzeppelin-unamed-selection-chromium

ui-next - modules-recipient--wallet-named-selection-chromium

modules-recipient--wallet-named-selection-chromium

ui-next - modules-recipient--wallet-preview-chromium

modules-recipient--wallet-preview-chromium

ui-next - modules-recipient--wallet-unamed-selection-chromium

modules-recipient--wallet-unamed-selection-chromium

ui-next - network--mainnet-chromium

network--mainnet-chromium

ui-next - network--sepolia-chromium

network--sepolia-chromium

ui-next - network--slot-chromium

network--slot-chromium

ui-next - network--unknown-chromium

network--unknown-chromium

ui-next - textarea--default-chromium

textarea--default-chromium

ui-next - toast--default-chromium

toast--default-chromium

profile - components-inventory-collection-send--default-chromium

components-inventory-collection-send--default-chromium

profile - components-inventory-token-send--default-chromium

components-inventory-token-send--default-chromium

@tarrencev
Copy link
Contributor

@bal7hazar one last thing, it seems like all the text got shifted up 1px

image

Copy link
Contributor

github-actions bot commented Feb 7, 2025

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 ui-next

🔄 Snapshot Updates in PR

The following snapshots have been updated in this PR:

  • button--default-chromium
  • button--disabled-chromium
  • button--ghost-chromium
  • button--medium-chromium
  • button--outline-chromium
  • button--secondary-chromium
  • button--with-icon-chromium
  • icons--brand-chromium
  • modules-amount--negative-amount-chromium
  • modules-amount--zero-decimals-chromium
  • modules-recipient--argent-confirmed-chromium
  • modules-recipient--argent-named-selection-chromium
  • modules-recipient--argent-preview-chromium
  • modules-recipient--argent-unamed-selection-chromium
  • modules-recipient--argent-validated-chromium
  • modules-recipient--braavos-named-selection-chromium
  • modules-recipient--braavos-preview-chromium
  • modules-recipient--braavos-unamed-selection-chromium
  • modules-recipient--controller-confirmed-chromium
  • modules-recipient--controller-named-selection-chromium
  • modules-recipient--controller-preview-chromium
  • modules-recipient--controller-validated-chromium
  • modules-recipient--default-chromium
  • modules-recipient--error-chromium
  • modules-recipient--open-zeppelin-preview-chromium
  • modules-recipient--openzeppelin-named-selection-chromium
  • modules-recipient--openzeppelin-unamed-selection-chromium
  • modules-recipient--wallet-named-selection-chromium
  • modules-recipient--wallet-preview-chromium
  • modules-recipient--wallet-unamed-selection-chromium
  • network--mainnet-chromium
  • network--sepolia-chromium
  • network--slot-chromium
  • network--unknown-chromium
  • textarea--default-chromium
  • toast--default-chromium

📦 profile

🔄 Snapshot Updates in PR

The following snapshots have been updated in this PR:

  • components-inventory-collection-send--default-chromium
  • components-inventory-token-send--default-chromium
🖼️ View All Image Changes

ui-next - button--default-chromium

button--default-chromium

ui-next - button--disabled-chromium

button--disabled-chromium

ui-next - button--ghost-chromium

button--ghost-chromium

ui-next - button--medium-chromium

button--medium-chromium

ui-next - button--outline-chromium

button--outline-chromium

ui-next - button--secondary-chromium

button--secondary-chromium

ui-next - button--with-icon-chromium

button--with-icon-chromium

ui-next - icons--brand-chromium

icons--brand-chromium

ui-next - modules-amount--negative-amount-chromium

modules-amount--negative-amount-chromium

ui-next - modules-amount--zero-decimals-chromium

modules-amount--zero-decimals-chromium

ui-next - modules-recipient--argent-confirmed-chromium

modules-recipient--argent-confirmed-chromium

ui-next - modules-recipient--argent-named-selection-chromium

modules-recipient--argent-named-selection-chromium

ui-next - modules-recipient--argent-preview-chromium

modules-recipient--argent-preview-chromium

ui-next - modules-recipient--argent-unamed-selection-chromium

modules-recipient--argent-unamed-selection-chromium

ui-next - modules-recipient--argent-validated-chromium

modules-recipient--argent-validated-chromium

ui-next - modules-recipient--braavos-named-selection-chromium

modules-recipient--braavos-named-selection-chromium

ui-next - modules-recipient--braavos-preview-chromium

modules-recipient--braavos-preview-chromium

ui-next - modules-recipient--braavos-unamed-selection-chromium

modules-recipient--braavos-unamed-selection-chromium

ui-next - modules-recipient--controller-confirmed-chromium

modules-recipient--controller-confirmed-chromium

ui-next - modules-recipient--controller-named-selection-chromium

modules-recipient--controller-named-selection-chromium

ui-next - modules-recipient--controller-preview-chromium

modules-recipient--controller-preview-chromium

ui-next - modules-recipient--controller-validated-chromium

modules-recipient--controller-validated-chromium

ui-next - modules-recipient--default-chromium

modules-recipient--default-chromium

ui-next - modules-recipient--error-chromium

modules-recipient--error-chromium

ui-next - modules-recipient--open-zeppelin-preview-chromium

modules-recipient--open-zeppelin-preview-chromium

ui-next - modules-recipient--openzeppelin-named-selection-chromium

modules-recipient--openzeppelin-named-selection-chromium

ui-next - modules-recipient--openzeppelin-unamed-selection-chromium

modules-recipient--openzeppelin-unamed-selection-chromium

ui-next - modules-recipient--wallet-named-selection-chromium

modules-recipient--wallet-named-selection-chromium

ui-next - modules-recipient--wallet-preview-chromium

modules-recipient--wallet-preview-chromium

ui-next - modules-recipient--wallet-unamed-selection-chromium

modules-recipient--wallet-unamed-selection-chromium

ui-next - network--mainnet-chromium

network--mainnet-chromium

ui-next - network--sepolia-chromium

network--sepolia-chromium

ui-next - network--slot-chromium

network--slot-chromium

ui-next - network--unknown-chromium

network--unknown-chromium

ui-next - textarea--default-chromium

textarea--default-chromium

ui-next - toast--default-chromium

toast--default-chromium

profile - components-inventory-collection-send--default-chromium

components-inventory-collection-send--default-chromium

profile - components-inventory-token-send--default-chromium

components-inventory-token-send--default-chromium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants