Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish yearly detailed FERC1 accounting tables #4057

Merged
merged 12 commits into from
Feb 13, 2025

Conversation

cmgosnell
Copy link
Member

@cmgosnell cmgosnell commented Feb 11, 2025

Overview

Closes #3642.

What problem does this address?

What did you change?

  • move where we are cleaning up the aggregate_{ dimension } columns
  • add income statement based table table and field schema
  • add assets table table and field schema
  • add liabilities table table and field schema
  • update alembic schema
  • clean out cols_to_keep cruft in boom

s# Documentation

Make sure to update relevant aspects of the documentation.

Tasks

Preview Give feedback

Testing

How did you make sure this worked? How can a reviewer verify this?

To-do list

Preview Give feedback

cmgosnell and others added 2 commits February 11, 2025 15:30
src/pudl/metadata/fields.py Outdated Show resolved Hide resolved
src/pudl/metadata/fields.py Outdated Show resolved Hide resolved
src/pudl/metadata/fields.py Show resolved Hide resolved
src/pudl/metadata/resources/ferc1.py Show resolved Hide resolved
src/pudl/metadata/resources/ferc1.py Show resolved Hide resolved
src/pudl/output/ferc1.py Outdated Show resolved Hide resolved
Copy link
Member

@aesharpe aesharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Comments are mostly nits that you can ignore if you feel it's OOS or not enough time. One high-level thought is to include more information about what one might expect to find in an assets, liabilities, income statement tables. The descriptions say "this table contains granular accounting data from utilities' XXX" but doesn't go into detail about what that might be.

src/pudl/metadata/fields.py Outdated Show resolved Hide resolved
src/pudl/metadata/fields.py Outdated Show resolved Hide resolved
"revenue_requirement_category": {
"type": "string",
"description": (
"A category of revenue requirement components. "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the way "category" and "component" are used here suggests nested categories and components that I think isn't what we're trying to convey. Maybe say: "categorized components of utility revenue requirements"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The category of revenue requirement associated with each component of utility's income statements. "?

Comment on lines 4061 to 4065
"The technology type associated with components of a utility's "
"revenue requirement. "
"These categories were mannually compiled by RMI utility accounting experts "
"based on the xbrl_factoid and sometimes vary based on the utility_type or "
"plant_function as well."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe call out the revenue_requirement_category column by name instead of referencing it by saying "components of a utility's revenue requirement"

src/pudl/output/ferc1.py Outdated Show resolved Hide resolved
@aesharpe aesharpe added the ferc1 Anything having to do with FERC Form 1 label Feb 12, 2025
@cmgosnell cmgosnell marked this pull request as ready for review February 13, 2025 00:14
@cmgosnell cmgosnell enabled auto-merge February 13, 2025 00:14
Copy link
Member

@aesharpe aesharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💛

@cmgosnell cmgosnell added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 3345bcd Feb 13, 2025
17 checks passed
@cmgosnell cmgosnell deleted the add-ferc1-detailed-accounting-tables branch February 13, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ferc1 Anything having to do with FERC Form 1
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Publish detailed accounting tables in DB
3 participants