-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish yearly detailed FERC1 accounting tables #4057
Conversation
src/pudl/package_data/ferc1/xbrl_factoid_revenue_requirement_tags.csv
Outdated
Show resolved
Hide resolved
Co-authored-by: Kathryn Mazaitis <[email protected]>
Co-authored-by: Kathryn Mazaitis <[email protected]>
Co-authored-by: Kathryn Mazaitis <[email protected]>
Co-authored-by: Austen Sharpe <[email protected]>
Co-authored-by: Austen Sharpe <[email protected]>
Co-authored-by: Austen Sharpe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Comments are mostly nits that you can ignore if you feel it's OOS or not enough time. One high-level thought is to include more information about what one might expect to find in an assets, liabilities, income statement tables. The descriptions say "this table contains granular accounting data from utilities' XXX" but doesn't go into detail about what that might be.
src/pudl/metadata/fields.py
Outdated
"revenue_requirement_category": { | ||
"type": "string", | ||
"description": ( | ||
"A category of revenue requirement components. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the way "category" and "component" are used here suggests nested categories and components that I think isn't what we're trying to convey. Maybe say: "categorized components of utility revenue requirements"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The category of revenue requirement associated with each component of utility's income statements. "?
src/pudl/metadata/fields.py
Outdated
"The technology type associated with components of a utility's " | ||
"revenue requirement. " | ||
"These categories were mannually compiled by RMI utility accounting experts " | ||
"based on the xbrl_factoid and sometimes vary based on the utility_type or " | ||
"plant_function as well." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe call out the revenue_requirement_category
column by name instead of referencing it by saying "components of a utility's revenue requirement"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💛
Overview
Closes #3642.
What problem does this address?
What did you change?
aggregate_{ dimension }
columnsboom
s# Documentation
Make sure to update relevant aspects of the documentation.
Tasks
Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list