Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebChucK IDE 2.1.4 #38

Merged
merged 22 commits into from
Oct 31, 2024
Merged

WebChucK IDE 2.1.4 #38

merged 22 commits into from
Oct 31, 2024

Conversation

terryzfeng
Copy link
Member

@terryzfeng terryzfeng commented Sep 11, 2024

Changes:

  • Export ChucK/WebChucK now has a descriptive .zip name
  • Improved WebChucK export modal interface and usage
  • Added GUI and Visualizer help prompts
  • Added "About IDE" under help for version info
  • Playing a shred now has green ANSI message (like miniAudicle)
  • New WebChucK sensors Gyro & Accel (thanks @mulshine)
  • Added notification pings for examples (GUI, HID, Sensor)
  • minor UI tweaks, bug fixes, and improvements

@terryzfeng terryzfeng marked this pull request as draft September 11, 2024 01:58
@terryzfeng terryzfeng self-assigned this Sep 11, 2024
@terryzfeng terryzfeng linked an issue Sep 11, 2024 that may be closed by this pull request
@terryzfeng terryzfeng changed the title WebChucK IDE 2.1.3 WebChucK IDE 2.1.3 [Draft] Sep 11, 2024
@terryzfeng terryzfeng changed the title WebChucK IDE 2.1.3 [Draft] WebChucK IDE 2.1.4 [Draft] Sep 11, 2024
@terryzfeng terryzfeng linked an issue Sep 11, 2024 that may be closed by this pull request
@terryzfeng terryzfeng requested a review from mulshine October 28, 2024 23:13
@terryzfeng
Copy link
Member Author

@mulshine I just added the Gyro and Accel to the IDE! These are all under a new Sensor tab and you can find the examples in the dropdown. Please test it out and I'd love to hear how it goes!

So far, it's working here and a lot of fun~

test: https://ccrma.stanford.edu/~tzfeng/webchuck-ide/

@mulshine
Copy link
Collaborator

mulshine commented Oct 29, 2024

Awesome! @terryzfeng <3

  1. I like the addition of the sine waves for the demos - makes the effect more noticeable!

  2. I was confused at first about how to enable the gyro/accelerometer in the Sensor settings. I wonder about (for at least the two demo examples) prompting the user when those examples are loaded (before the program runs). In other custom code, users will (by then) know where to enable gyro/accel. (Alternatively, code parsing for "Accel"/"Gyro" objects and when the shred is added, we prompt if necessary).

  3. If I leave the browser / lock my phone, then return, neither demo makes sound anymore, and time doesn't pass in the remaining shred. I also can't remove or add a shred. Fixed by refreshing page. This happens even with HelloSine, so I think it's a WebChucK IDE issue that you may already be aware of. How do you think we could resolve this? I think we'd need to do the opposite of "Start WebChucK" when the browser context is lost (e.g. Stop WebChucK), remove all shreds, and likely just need to have the user start it again. I don't see another way around it really, unless when the browser context is gained back we just need to do another theChucK.audioContext.resume() call?? That might be it actually...

  4. Feels like a little more latency than outside the IDE (e.g. mikemulshine.com/accel). Is it just the IDE overhead?

Otherwise I think it's pretty good to go :)

@terryzfeng terryzfeng marked this pull request as ready for review October 29, 2024 03:51
@terryzfeng terryzfeng changed the title WebChucK IDE 2.1.4 [Draft] WebChucK IDE 2.1.4 Oct 29, 2024
@terryzfeng
Copy link
Member Author

terryzfeng commented Oct 29, 2024

  1. Haha I didn't change the examples, that's just your code :D
  2. I think it's possible to add a dot or something when loading an example! I can try that out if it's easy!
  3. Interesting. On Android, the sound just continues (although crackles cause background thread). I haven't run into this issue yet. If you'd like to file an issue perhaps? @mulshine
  4. Oof, I hope it's not too bad. Maybe turning off logging could make it faster? But I do notice from time to time that the IDE could be faster...

I'll try to tackle 2 and hopefully we can kick the other cans down the road... :)

@mulshine
Copy link
Collaborator

Thanks @terryzfeng :)

  1. Ahh my bad! I don't know why it felt different for me in the IDE. Might have just been the latency.
  2. Probably not highest priority.
  3. I will file an issue.
  4. Yeah, maybe we can at least have an option to toggle on/off logging (of all sorts?) to improve latency? Should this be another issue?

@mulshine
Copy link
Collaborator

I think otherwise good to merge! @terryzfeng

Copy link
Collaborator

@mulshine mulshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@terryzfeng
Copy link
Member Author

Thanks Mike! I can file an issue for turning off logging! The notification pings work great! Thanks for the suggestion!

@terryzfeng terryzfeng merged commit 8c6c7c0 into main Oct 31, 2024
2 checks passed
@terryzfeng terryzfeng linked an issue Jan 25, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants