Add steps for CDF BYOID login test #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsankit-google
requested changes
Jul 29, 2024
There was a problem hiding this comment.
Looks like some checkstyle issues in the PR:
Error: /tmp/cdap-e2e-tests/cdap-e2e-tests/e2e/src/main/java/io/cdap/e2e/pages/actions/CdfSignInActions.java:60: Line is longer than 120 characters (found 124). [LineLength]
Error: /tmp/cdap-e2e-tests/cdap-e2e-tests/e2e/src/main/java/io/cdap/e2e/pages/actions/CdfSignInActions.java:63: Line is longer than 120 characters (found 124). [LineLength]
Error: /tmp/cdap-e2e-tests/cdap-e2e-tests/e2e/src/main/java/io/cdap/e2e/pages/actions/CdfSignInActions.java:64: Line is longer than 120 characters (found 124). [LineLength]
@poojantcs please ensure build is green before PR is raised for review.
adrikagupta
reviewed
Jul 30, 2024
| @@ -6,6 +6,8 @@ cdfurl=http://localhost:11011/pipelines/ns/default/studio | |||
| cdfConnectionsUrl=http://localhost:11011/cdap/ns/default/connections | |||
| # CDAP Replication url | |||
| replicationUrl=http://localhost:11011/cdap/ns/default/replication/create | |||
| # CDF BYOID url | |||
| cdfbyoidurl=https://test-byoid-cdf-url/ | |||
There was a problem hiding this comment.
Will this instance be in cdf-byoid project?
There was a problem hiding this comment.
This is a placeholder CDF URL text. It will be replaced by the Cloud build with the targeted CDF instance URL.
poojantcs
force-pushed
the
stepsForByoidTest
branch
from
d80c9af to
3c8da48
Compare
itsankit-google
requested changes
Aug 20, 2024
itsankit-google
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Looks like it related to hadoop upgrade PR: data-integrations/google-cloud#1427
Not related to current changes, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.