e2e error details fix #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnkitCLI
force-pushed
the
e2e_errordetailschange
branch
3 times, most recently
from
56c9295 to
a0ea726
Compare
| @@ -44,7 +44,8 @@ public class WranglerActions { | |||
| * @param directive The directive to be selected for the column. | |||
| */ | |||
| public static void selectDirective(String columnName, String directive) { | |||
| WaitHelper.waitForPageToLoad(); | |||
| WaitHelper.waitForPageToLoad(180); | |||
There was a problem hiding this comment.
we can use the existing constant everywhere:
AnkitCLI
force-pushed
the
e2e_errordetailschange
branch
from
a0ea726 to
d61405d
Compare
itsankit-google
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains error fix for stale element in capturing error message on UI.