Remove letter queues #2454
Open
Remove letter queues #2454
+9
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcmurtry
commented
Feb 12, 2025
| @@ -267,14 +267,14 @@ def send_notification_to_queue(notification, research_mode, queue=None): | |||
| if notification.sends_with_custom_number(): | |||
| deliver_task = provider_tasks.deliver_throttled_sms | |||
| queue = QueueNames.SEND_THROTTLED_SMS | |||
| if not queue or queue == QueueNames.NORMAL: | |||
| if not queue: | |||
There was a problem hiding this comment.
This looks like a fallback that was used when the sms/email specific queues were released. It is no longer possible to have QueueNames.NORMAL as far as I can tell.
There was a problem hiding this comment.
Let's test the 💩 out of this before releasing with some bug bash?
There was a problem hiding this comment.
Sounds good! I will wait until Monday to merge this.
jimleroyer
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This PR removes the following celery queues:
bulk-tasks,priority-tasks, andnormal-tasks. These have been replaced with sms and email specific queues and they were only being used for letter sending, so they should be safe to remove.