Implement discrete optical physics #1604
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idation checks into separate file
…y require real_types
… RefactorOpticalMockTests
…tas into RefactorOpticalMockTests
…size_type instead of size_t
… RefactorOpticalMaterials
hhollenb
added
enhancement
Test summary 4 516 files 6 942 suites 15m 32s ⏱️ For more details on these failures, see this check. Results for commit 6620556. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of
PhysicsDataand associated views necessary to do volumetric optical physics.PhysicsParamsclosely matches the core physics version, but slimmed down just for discrete interactions. TheDiscreteSelectAction,PhysicsTrackView, andPhysicsStepViewwere implemented similarly. I've updated the hooks into the core optical classes so executors should have access to physics data.Currently only absorption and rayleigh models are implemented, and I've limited the importing of models in tests to just those two.
I've left the executor implementation empty for the moment to reduce the overall complexity of the merge. I can start working on them and adding them to this PR. I can also add some extra device tests and I/O tests for optical data.