Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test removing the CNAME file for clean up of previews. #1493

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

MSevey
Copy link
Member

@MSevey MSevey commented Mar 21, 2024

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • Chores
    • Removed the step for adding a CNAME file before deploying previews in the GitHub workflow.

@MSevey MSevey requested a review from jcstein March 21, 2024 18:23
Copy link
Contributor

coderabbitai bot commented Mar 21, 2024

Walkthrough

This update involves simplifying the deployment process for preview environments by eliminating the step where a CNAME file was previously added. This change streamlines the workflow, potentially speeding up the deployment process and reducing complexity.

Changes

File Change Summary
.github/workflows/preview.yml Removed step for adding CNAME file before deployment

🐰✨
In the realm of code where the bits gently hop,
A small change was made, a tiny step dropped.
No more CNAMEs to add, in the workflow's sweep,
Making deployments quicker, as through the net they leap.
🚀💨
"Hop, skip, and a jump," the rabbit declares,
As the code flows smoother, with lesser cares.
🌟🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

github-actions bot commented Mar 21, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-03-21 18:29 UTC

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 690aece and abeb812.
Files selected for processing (1)
  • .github/workflows/preview.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/preview.yml

@MSevey MSevey enabled auto-merge (squash) March 21, 2024 18:28
@MSevey MSevey merged commit 32706e1 into main Mar 21, 2024
4 checks passed
@MSevey MSevey deleted the MSevey-patch-1 branch March 21, 2024 18:28
rach-id added a commit that referenced this pull request Apr 18, 2024
…stream (#1489)

* docs: add documentation on how to build rollups on Celestia

* docs: remove question

* docs: one -> value

* docs: explain more the proofs + reformating

* docs: set ETA

* docs: expand on protobuf deserialisation

* docs: expand on protobuf deserialisation

* docs: rewrite, reorganise, explain

* docs: review feedback

* docs: grammar

* docs: remove new lines

* docs: add links to inclusion proofs

* docs: update blobstream contract addresses (#1485)

Replaces #1482

* ci: test removing the CNAME file for clean up of previews. (#1493)

* docs: update blobstream (#1495)

* docs: update bubs-testnet.md with new URIs

* docs: add status page and bridge

* docs: comment out thirdweb bc chain is different now

* docs: update gm portal and contract guides for bubs

* docs: add mocha and namespace

* docs: add bridging context

* [GH Action] Update release tags and commit SHAs for arabica (#1497)

* [automated GH action] update latest release tags & commit sha (arabica)

* Update .vitepress/constants/arabica_versions.js

---------

Co-authored-by: jcstein <[email protected]>
Co-authored-by: Josh Stein <[email protected]>

* [GH Action] Update release tags and commit SHAs for mocha (#1498)

* [automated GH action] update latest release tags & commit sha (mocha)

* Update .vitepress/constants/mocha_versions.js

---------

Co-authored-by: jcstein <[email protected]>
Co-authored-by: Josh Stein <[email protected]>

* docs: update go constants for arabiac and mocha

* docs: update to make install for all types of machines (#1502)

* feat: Update node-tutorial.md (#1478)

this is live in v0.13.0 i think, cc @vgonkivs for review

* feat: split consensus node page (#1472)

* docs: split consensus node page

* docs: setup to set up

* docs: setup to set up 2

* docs: coderabbit reviews

* docs: change to  everywhere

* docs: add backlink

---------

Co-authored-by: jcstein <[email protected]>

* docs: rollup available link Vitalik (#1505)

* docs: rollup link Vitalik

* docs: changes follow suggestion for example giving comma

* docs: Fix proof query example errors (#1504)

* Add missing return statement in toRowProofs function

* fix dataRoot slice out of range error

* fixes another missing return in toRowProofs

* docs: fix blobstream proof queries code (#1506)

* docs: initial commit, needs revision

* docs: remove old light node config

* docs: edits and refactor page

* docs: minor copy edit

* docs: cleanup for new deployment guide

* docs: todos for deployment guide

* docs: edit intro

* docs: step 1-2

* docs: deploy steps and table

* docs: remainder of deploy steps draft

* docs: change style of quickstart to Quickstart: Deploy an Orbit rollup

* docs: add todos

* docs: update contract addresses

* docs: using light node, namespace, auth token

* docs: add link to arb doc

* docs: add todo

* docs: resolve build errs

* docs: add bridging guide

* docs: small revisions

* docs: copy edits

* docs: deploy revision

* docs: fix blobstream address

* docs: add alchemy rpc section

* docs: note about opening ports in docker

* docs: bump celestia-node version

* docs: edit l1 to l2

* docs: add newer success logs

* feat: add full node page to docs for orbit

* feat: write out full node page

* docs: more info on validatorfn page

* docs: update wasm root

* docs: update nitro release

* docs: use v2.3.1-rc.1 everywhere for nitro

* docs: edit out 'click heres'

* fix: links

* docs: add eth-rpc variable

* docs: coderabbit suggestions

* docs: clarify wss

* docs: swap steps 6 and 7 for deploy doc

* docs: edit wss section

* docs: add more context for wss

* docs: improve md readabliity in table

* docs: update deployui url

* docs: update ui url

* docs: we'll use in next step

* docs: updates

* docs: add fn

* [GH Action] Update release tags and commit SHAs for mainnet (#1507)

* [automated GH action] update latest release tags & commit sha (mainnet)

* Update .vitepress/constants/mainnet_versions.js

---------

Co-authored-by: jcstein <[email protected]>
Co-authored-by: Josh Stein <[email protected]>

* docs: update newmetric endpoints

Resolves #1501

* docs: update orbit URL

* docs: coderabbit suggestions

* docs: add op raspberry testnet

* [GH Action] Update release tags and commit SHAs for arabica (#1511)

* [automated GH action] update latest release tags & commit sha (arabica)

* Apply suggestions from code review

---------

Co-authored-by: jcstein <[email protected]>
Co-authored-by: Josh Stein <[email protected]>

* docs: add sepolia -> mocha (#1512)

* fix typo in arabica-devnet page (#1513)

* [WIP] docs: add audits for blobstream x (#1491)

* docs: add audits for blobstream x

* docs: add veridise audit

* Update rollup-overview.md (#1516)

* feat: restructure developers category (#1515)

* feat: drafting buttons

* fix: color of btn

* feat: add note text optional

* feat: rename to build-whatever.md

* fix: copy

* feat: category shuffle

* fix: suggestions from code review

* feat: add vistara

* Apply suggestions from code review

* fix: typo

* feat: add alt texts

* fix: typo

* feat: aria-labels

* docs: shuffle intro

* feat: add celestia-node.sh script

* fix: clarify section vs. tutorial

* feat: exit if dir change fails

* Update mocha_versions.js (#1529)

* Update mocha_versions.js

* Update mocha_versions.js

* Add Grove archival endpoints to `nodes/mainnet.md` (#1525)

* Add Grove to nodes/mainnet.md

* Apply suggestions from code review

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update nodes/mainnet.md

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Store image in src code

* Add description of archival nodes

* Apply suggestions from code review

* Apply suggestions from code review

* Update nodes/mainnet.md

---------

Co-authored-by: joshcs.eth <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* docs: fix typos (#1526)

* fix typo

* fix typo

* fix typo

* fix typo

* fix typos

* fix typo

* fix typo

* fix typos

* fix typos

* fix typos

* fix typos

* fix typo

* fix typo

* fix typo

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Apply suggestions from code review

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: joshcs.eth <[email protected]>

* Update mainnet.md (#1527)

Add noders endpoints

* Update mocha-testnet.md (#1528)

* Update mocha-testnet.md

Add noders endpoints

* Fixed link to endpoint

* Apply suggestions from code review

---------

Co-authored-by: joshcs.eth <[email protected]>

* fix: veridise path

* feat: add to menu

* docs: begin lint

* docs: remove duplicate headings

* docs: clarify duplicate headings

* docs: better headings

* docs: mention blobstream rollups docs in the blobstream overview

---------

Co-authored-by: Josh Stein <[email protected]>
Co-authored-by: Matthew Sevey <[email protected]>
Co-authored-by: jcstein <[email protected]>
Co-authored-by: celestia-bot <[email protected]>
Co-authored-by: jcstein <[email protected]>
Co-authored-by: Levai Mackenzie Ágbàrà <[email protected]>
Co-authored-by: Guspan Tanadi <[email protected]>
Co-authored-by: Kassius <[email protected]>
Co-authored-by: Ratan Kaliani <[email protected]>
Co-authored-by: Callum Waters <[email protected]>
Co-authored-by: Alex Beckett <[email protected]>
Co-authored-by: mindstyle85 <[email protected]>
Co-authored-by: Daniel Olshansky <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: omahs <[email protected]>
Co-authored-by: Alex Moskaleu (SeptimA) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants