Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lava RPC Endpoints to Mainnet Beta and Mocha Testnet Documentation #1856

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Add Lava RPC Endpoints to Mainnet Beta and Mocha Testnet Documentation #1856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions how-to-guides/mainnet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,8 @@ on [service providers with SLAs](#production-rpc-endpoints).
- `celestia-api.chainode.tech`
- `celestia-mainnet-api.itrocket.net:443`
- `celestia-api.noders.services`
- `celestia.rest.lava.build`


#### Community gRPC endpoints

Expand All @@ -192,6 +194,8 @@ on [service providers with SLAs](#production-rpc-endpoints).
- `celestia-grpc.chainode.tech:443`
- `celestia-mainnet-grpc.itrocket.net:443`
- `celestia-grpc.noders.services:11090`
- `celestia.grpc.lava.build:443`

Comment on lines +197 to +198
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Missing JSON-RPC and Tendermint RPC endpoints confirmed

The review comment is correct. The mainnet documentation is missing the following Lava endpoints:

  • celestia.jsonrpc.lava.build
  • celestia.tendermintrpc.lava.build
🔗 Analysis chain

Missing JSON-RPC and Tendermint RPC endpoints

According to the PR objectives, JSON-RPC and Tendermint RPC endpoints should be added for both networks. These endpoints are missing for the mainnet:

  • celestia.jsonrpc.lava.build
  • celestia.tendermintrpc.lava.build
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify if sections for JSON-RPC and Tendermint RPC endpoints exist in the file
rg -i "json-rpc|tendermint rpc" how-to-guides/mainnet.md

Length of output: 58

Script:

#!/bin/bash
# Get the content of mainnet.md and testnet.md if exists
echo "=== Content of mainnet.md ==="
cat how-to-guides/mainnet.md

echo -e "\n=== Searching for endpoint-related content in testnet docs ==="
fd testnet.md --exec cat {}

echo -e "\n=== Searching for any endpoint references ==="
rg -i "endpoint|rpc|\.build" how-to-guides/

Length of output: 66917

Script:

#!/bin/bash
# Search specifically for jsonrpc and tendermintrpc patterns in mainnet.md
echo "=== Searching for JSON-RPC and Tendermint RPC endpoints ==="
rg -i "jsonrpc\.lava\.build|tendermintrpc\.lava\.build" how-to-guides/mainnet.md

echo -e "\n=== Checking if there are dedicated sections for these endpoint types ==="
rg -i "## .*(json-rpc|tendermint rpc).*endpoints" how-to-guides/mainnet.md

Length of output: 451


#### Community WebSocket endpoints

Expand Down
11 changes: 11 additions & 0 deletions how-to-guides/mocha-testnet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ The default port is 1317.
- [https://celestia-testnet-api.itrocket.net](https://celestia-testnet-api.itrocket.net)
- [https://api-celestia-testnet.cryptech.com.ua](https://api-celestia-testnet.cryptech.com.ua)
- [https://celestia-t-api.noders.services](https://celestia-t-api.noders.services)
- [http://celestiam.rest.lava.build](http://celestiam.rest.lava.build)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider using HTTPS for the API endpoint

The API endpoint is using HTTP which is less secure. Consider using HTTPS instead for enhanced security.

- - [http://celestiam.rest.lava.build](http://celestiam.rest.lava.build)
+ - [https://celestiam.rest.lava.build](https://celestiam.rest.lava.build)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- [http://celestiam.rest.lava.build](http://celestiam.rest.lava.build)
- [https://celestiam.rest.lava.build](https://celestiam.rest.lava.build)


## Community gRPC endpoints

Expand All @@ -174,6 +175,16 @@ broadcast transactions.
- `celestia-testnet-grpc.itrocket.net:443`
- `grpc-celestia-testnet.cryptech.com.ua:443`
- `celestia-t-grpc.noders.services:21090`
- `celestiam.grpc.lava.build:443`

## Community JSON-RPC Endpoints

- `celestiam.jsonrpc.lava.build`

## Community Tendermint RPC Endpoints

- `celestiam.tendermintrpc.lava.build`


## Community bridge and full node endpoints

Expand Down
Loading