Add pre_condtime for preconditioning and allow multiple randrw workloads within the same YAML #326
Conversation
Signed-off-by: Chris Harris([email protected]
Signed-off-by: CHris Harris([email protected])
- specify a precond_time in the preconditioning workload of a RBD YAML
that is using the workloads feature. So you can have a different
length of preconditioning time compared to a regular runtime (time in
the YAML)
- Fixes an issue where if you specified more than one workload with the
same block size, but with different rwmixread ratios, the 2nd workload
would overwrite the 1st workloads results log file.
Signed-off-by: lee-j-sanders <[email protected]>
|
Note, at the moment this is based on #324 due to changes in the same area - at the time of writing PR324 is unmerged hence the PR324 changes are appearing in the review. |
|
================================================================================================== test session starts ================================================================================================== tests/test_benchmarkfactory.py ... [ 0%] =================================================================================================== warnings summary ==================================================================================================== -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html The warning looks to be a problem in master with the common output formatter stuff, not anything I've introduced. I will look into this with @harriscr before merging. |
Signed-off-by: lee-j-sanders <[email protected]>
| @@ -29,6 +29,8 @@ def __init__(self, archive_dir, cluster, config): | |||
| self.recov_test_type = config.get('recov_test_type', 'blocking') | |||
| self.data_pool_profile = config.get('data_pool_profile', None) | |||
| self.time = config.get('time', None) | |||
| self.precond_time = config.get('precond_time',None ) | |||
There was a problem hiding this comment.
If you look at the way workloads work, basically they temporarily overwrite the global FIO options defined in the test plan .yaml (normally located before the workloads section). So within a precondition one can set a time value that only affects the precondition, which is then restored to the global. Then, another workload step would do the same.
In other words, there is not actual need to introduce yet another 'precond_time'!
But you can do the experiment: define two different time values in a precond and a workload step, from the global ones, with the existing code (that is, without this change) to convince yourself.
There was a problem hiding this comment.
And this is also mentioned in the documentation https://github.com/ceph/cbt/blob/master/docs/Workloads.md
This PR only changes the functionality of workloads.
If workloads are in use, and there is a preconditioning step within the YAML, often users will want to run preconditioning for say 10 minutes, where as each other workload will run for a shorter period of time, this PR allows the user to override time with precond_time and specify precond within the preconditioning step to use the different time attribute.
Additionally, workloads with randrw only let you specify 1 mixed workload within a YAML as the same directory name was used for the subsequent randrw workloads, thus overwriting all the previous results in the archive directory with the later tests. This PR adds the readwrite ratio into the directory name if the mode is randrw.
The directory name for 100% read and 100% write tests are unaffected.