Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Resolve array types with module code in dyno #26628

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

[wip] Resolve array types with module code in dyno #26628

wants to merge 27 commits into from

Conversation

riftEmber
Copy link
Member

@riftEmber riftEmber commented Jan 30, 2025 •
edited
Loading

Add support for array type expressions using default rectangular or associative domains.

Part of https://github.com/Cray/chapel-private/issues/6730.

Future work:

  • Implement noinit, which will adjust this implementation code's initElts

[reviewer info placeholder]

Depends on #26679 which should be merged first.

Testing:

  • dyno tests
  • paratest

@riftEmber riftEmber force-pushed the resolve-array-type branch 13 times, most recently from 257083c to abacc66 Compare February 4, 2025 21:06
@riftEmber riftEmber mentioned this pull request Feb 4, 2025
Merged
3 tasks
@riftEmber riftEmber force-pushed the resolve-array-type branch 7 times, most recently from bfc24ed to 21f3629 Compare February 5, 2025 18:28
@riftEmber riftEmber changed the title [wip] dyno resolve array module code [wip] Resolve array type expressions with module code in dyno Feb 5, 2025
riftEmber added a commit that referenced this pull request Feb 5, 2025
@riftEmber
Fix call resolution search order for forwarded proc as method (#26650)
fedc360 
Fix a bug where Dyno would consider forwarded method candidates even
when non-forwarded function candidates were found, for a call within a
method.

We only want to search for forwarding candidates if we haven't found any
non-forwarding candidates. However, when resolving a call in a method,
we first try resolving it as a function and then as a method with an
implicit receiver. If we find function candidates, we still want to
search for method candidates, but we do not want to search for
forwarding method candidates even if there are no non-forwarding method
candidates. This PR adds logic to skip that.

Added a test for the fixed case, where the test would previously
encounter ambiguity between the non-forwarded function and forwarded
method.

This bug was incidentally causing query recursion in
Cray/chapel-private#7087, where the definition
of `chpl__promotionType` on `_array` relies on the correct search order.

Resolves Cray/chapel-private#7087.

[reviewed by @DanilaFe , thanks!]

Testing:
- [x] dyno tests
- [x] paratest
- [x] fixes Cray/chapel-private#7087 (in
combination with [basic array
resolution](#26628))
@riftEmber riftEmber force-pushed the resolve-array-type branch 6 times, most recently from 64a6fe8 to a8b3ea1 Compare February 7, 2025 18:50
@riftEmber riftEmber changed the title [wip] Resolve array type expressions with module code in dyno [wip] Dyno resolve rectangular and associative array types Feb 7, 2025
DanilaFe and others added 26 commits February 7, 2025 13:38
@DanilaFe @riftEmber
Add 'default initializable' primitive
3128b45 
Signed-off-by: Danila Fedorin <[email protected]>
@DanilaFe @riftEmber
Expose "has default value" via primitive
15227ce 
Signed-off-by: Danila Fedorin <[email protected]>
@DanilaFe @riftEmber
Add tests
64c3633 
Signed-off-by: Danila Fedorin <[email protected]>
@riftEmber
Build domain from range literal in array type expr
7d45be0 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Add error for invalid domain in array type
a3a7ad9 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Remove minimal test version of ChapelArray
060543a 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Add basic assertions for subs in getArrayType
8b50429 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Hook up resolution with buildArray
1195cbc 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Return generic array for generic domain
7c8a175 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Keep eltType info in generic-domain array
6e5af96 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Replace compiler-generated _array .domain and .eltType
a52219c 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Resolve .domain without _dom call
5b86005 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Only keep eltType in generic-domain arr if resolved
f0f7d9d 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Allow empty or type query eltType
2184acd 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Fix incorrect module number in testArrays
2079d16 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Use AnyType _instance for partially generic array
8d2d5dc 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Fix _instance of domain extracted from array
6c4f96d 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Emit array being tested at start of test
b865c7b 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Allow domain type query in array type
4a535fd 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Allow empty domain part in array type
209ecd4 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Don't error out on unknown domain type
180411b 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Fix expected class for associative and sparse arrays
d9acc6c 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Implement associative array type resolution
5348350 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Autoformat
7f53e11 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Go back to resolving _dom call for .domain
49c96b6 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber
Correct value for initElts and clarify TODO
158945f 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber riftEmber changed the title [wip] Dyno resolve rectangular and associative array types Resolve array types with module code in dyno Feb 7, 2025
@riftEmber riftEmber changed the title Resolve array types with module code in dyno [wip] Resolve array types with module code in dyno Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riftEmber @DanilaFe